Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference
SDK-2488 -- [Android] [Spike] Factor out persisted events/ In-memory only execution
Description
Behavior between the iOS and Android SDKs concerning what to do with "cached events" has been inconsistent and has led to undesirable behavior. This PR simply removes the notion of cached events, which are read from disk only when the Branch Singleton instance is initialized.
Events that fail during app foreground (no internet, failed server request) are not stored and are thus lost, never persisted to the disk. Further, only opens were able to be serialized. #1215
v1/url
was serialized, but never replayed.Background processing of events is not yet in scope.
Keeping utility function as other unrelated tests have a dependency on manually creating
ServerRequest
objects.Testing Instructions
Prior behavior: open events will be added to the queue and persisted. Immediately background and close the app before the network request is executed and the request will be replayed.
After: SDK skips this steps and proceeds to process new open request, by design.
Risk Assessment [
LOW
]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.