fix: ensure that no fueled generators with zero heat rate can be built

[danielolsen]

Pull Request doc

Purpose

Ensure that no fueled generators with zero heat rate can be built. Closes #117.

What the code is doing

We add one new pandas dataframe assignment to effect this change:

df.loc[
    (
        df.index.isin(indices["expansion"])
        & (df.gen_full_load_heat_rate == 0)
        & df.gen_energy_source.isin(const.fuels)
    ),
    "gen_capacity_limit_mw",
] = 0

Two other pandas assignments are moved, so that the logical flow of the function is:

1. Add columns to the data frame (full columns)
2. Refine the data in the data frame (partial column re-assignments)

Testing

Tested manually using the code snippet from #117. The only changed information are the ten expansion candidates previously identified, and the new values should produce a hard limit that prevents them from being expanded.

Time estimate

15 minutes.

[BainanXia]

This only closes #117 partially, right? Eventually, we will need meaningful heat rate rates for generators with 0 Pmax. One immediate application would be the case in which we would like to add a hypothetical plant with fuel but no such plant exists in the same location.

[BainanXia]

This will prevent Switch from building generation capacities if heat rate is zero for a power plant consuming fuel.

[danielolsen]

This only closes #117 partially, right? Eventually, we will need meaningful heat rate rates for generators with 0 Pmax. One immediate application would be the case in which we would like to add a hypothetical plant with fuel but no such plant exists in the same location.

It fixes what I consider as the main problem from #117, that the inputs are currently being prepared in a way that they should not be. I think your example would fall under the umbrella of #69.