Ico updates #35
Open
Ico updates #35
+12,390
−9,290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require creation date on recovery, build latest styling
Remove old datepicker module, wait for both daemons to be loaded
Disabled strict password requirements
Change default ports
…pdate updated full node submodule
Make text more understandable
Make label more understandable
Small aesthetic change
Remove to/from from transaction details
Fix failing recovery message
Fix decrypt disable
…pdate updated full node submodule
…andling spaces in names.
Local build scripts
Update logos to 512x512
…pdate updated StratisBitcoinFullNode submodule
updated SBFN path
…pdate updated StratisBitcoinFullNode submodule
fenix2222
reviewed
Aug 7, 2018
| <label style="font-size:10px">Working...</label> | ||
| </div> | ||
| </div> | ||
| <div class="alert alert-danger" role="alert" *ngIf="errored"> | ||
| <label>{{erroredText}}</label> | ||
| <div *ngIf="errored"> |
There was a problem hiding this comment.
Is ngSwitch more appropriate here as we are showing divs based on state? https://angular.io/api/common/NgSwitch. Also would be good to get rid of inline styles and combine into common class
| /> | ||
| <app-feedback *ngIf="!generateAddressesLoadingState.success" style="margin-left:5px; width:115px" [loading]="generateAddressesLoadingState.loading" | ||
| [errored]="generateAddressesLoadingState.errored" [erroredText]="'Failed'"></app-feedback> | ||
| <app-feedback style="margin-left:5px; width:115px" [loading]="generateAddressesLoadingState.loading" [success]="showAddressesTick" |
There was a problem hiding this comment.
Is there any way to move this to a css class instead of inline styles?
|
There are also conflicts |
fenix2222
reviewed
Aug 7, 2018
| @@ -12,14 +12,16 @@ import { LoadingState } from './loadingState'; | |||
| styleUrls: ['./advanced.component.css'] | |||
| }) | |||
| export class AdvancedComponent implements OnInit, OnDestroy { | |||
| private addressCount: string; | |||
| private addressCount = ""; | |||
| <button *ngIf="addressCountControl.invalid || !addressCount" style="color: gray; outline:none" class="btn btn-default" type="button">Go</button> | ||
| </div> | ||
| </span> | ||
| <div style="display: flex; flex-direction: row; margin-top:30px"> |
| if (response.json().transactionsHistory.length > 0) { | ||
| historyResponse = response.json().transactionsHistory; | ||
| const json = response.json(); | ||
| if (json.transactionsHistory) { |
There was a problem hiding this comment.
What happens if response doesn't have transactionsHistory? Should we log it or report it to user?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://stratisplatformuk.visualstudio.com/Stratis%20Core%20-%20Breeze%20Wallet/_workitems/edit/2100
Breeze ICO updates - complete, ready for review.
@fenix2222