Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #125

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Update #125

wants to merge 14 commits into from

Conversation

Breta01
Copy link
Owner

@Breta01 Breta01 commented Apr 2, 2020

Trying to implement changes introduced in issue: #64
Branch will be merged once it is stable.

@Breta01 Breta01 self-assigned this Apr 2, 2020
@Breta01 Breta01 mentioned this pull request Apr 3, 2020
Closed
@Breta01 Breta01 mentioned this pull request Apr 7, 2020
Open
Breta01
Breta01 commented Apr 9, 2020
View reviewed changes
.flake8 Outdated Show resolved Hide resolved
README.md
* Pandas (0.21)
* Matplotlib (2.1)

### Run
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write better documentation on usage. Example sections https://gist.github.com/jxson/1784669

handwriting_ocr/data/data_extractor.py Outdated Show resolved Hide resolved
handwriting_ocr/ocr/datahelpers.py
'n', 'o', 'p', 'q', 'r', 's', 't', 'u', 'v', 'w',
'x', 'y', 'z', '0', '1', '2', '3', '4', '5', '6',
'7', '8', '9', '.', '-', '+', "'"]
CHARS = [
Copy link
Owner Author

@Breta01 Breta01 Apr 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix code black formatting on this. Even better, instead use printable characters from string (or some subset)

@Breta01
Copy link
Owner Author

Breta01 commented Apr 17, 2020 •
edited
Loading

TODO:

  • Figure out how to do versioning of jupyter notebooks It seems that limiting usage of jupyter notebooks is the best approach. I will slowly switch to using notebooks only for documentation of main features.
  • Use black formatting in jupyter notebooks

@eMPee584
Copy link

Branch will be merged once it is stable.

(Maybe rather create a stable branch and release tags?)

@Breta01
Copy link
Owner Author

Breta01 commented Jul 11, 2020

@eMPee584 I agree that that is better approach. Reason for this branch is that I want to make quite a big changes which will be hardly compatible with current state in master. I am bit busy with other stuff right now, but hopefully I will be able to finish this as soon as possible.

Any help would be highly appreciated. Thanks

@PastaLaPate
Copy link

Are you still looking for help ?

@Breta01
Copy link
Owner Author

Breta01 commented Jul 18, 2024

@PastaLaPate sure! I don't have time to work on this project. But if you propose any changes, I can review them and merge the pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Breta01 Breta01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Breta01 @eMPee584 @PastaLaPate