replace / with _ in beer names #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue BrewPi#29 We use the beer name as part of the file path for saving data... no problems there if we use MyBeer as a name, the path is /path/to/MyBeer . However, if we use My/Beer as the name, the filepath becomes /path/to/My/Beer and breaks everything. We simply replace / with _ to avoid this problem. Note- Windows has a TON of restricted chars and COMBOS of chars that are restricted, but not addressed in this patch.
|
The names are escaped in the web interface now. Should we still do it here? |
|
You can do it either way... I'm probably biased b/c I dont do web stuff, but I think you'd want to do it here, or atleast check it here, at minimum just to serve as a reminder that sanitization is being done on it (when something else breaks). I think a 'new person' to the code's first intuition would be to check here. But, I am biased! I don't think there's a wrong answer. |
|
I agree that escaping the slash is a sound idea, even if it is done elsewhere too. Can you submit this pull request against develop instead? |
|
Done! Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #29
We use the beer name as part of the file path for saving data... no problems there if we use MyBeer as a name,
the path is /path/to/MyBeer . However, if we use My/Beer as the name, the filepath becomes /path/to/My/Beer and
breaks everything. We simply replace / with _ to avoid this problem. Note- Windows has a TON of restricted chars
and COMBOS of chars that are restricted, but not addressed in this patch.