Update docker setup to include migrations #189
Conversation
| @@ -1,11 +1,32 @@ | |||
| FROM node:16.13.1-alpine3.15 | |||
| # syntax=docker/dockerfile:1 | |||
| FROM node:lts-alpine3.17 as builder | |||
There was a problem hiding this comment.
Wouldn't it be better to specify the exact version so if someone else pulls the dockerfile later on doesn't get a different minor version?
There was a problem hiding this comment.
Also, what were the benefits of having a builder stage? Wouldn't it mean that the builder stage is not cached and every release would have to reinstall the node modules part even if it's just a change in a string in our code?
| COPY --from=builder /app/package*.json ./ | ||
| COPY --from=builder /app/build ./build | ||
| COPY --from=builder /app/prisma ./prisma | ||
| COPY --from=builder /app/prisma/database.empty ./prisma/db/main.db |
There was a problem hiding this comment.
I'm not a fan of doing this type of renames instead of having the same filename inside and outside, so I would suggest having the same name.
There was a problem hiding this comment.
However since this is for a production Dockerfile only for now is not as bad.
| COPY --from=builder /app/prisma ./prisma | ||
| COPY --from=builder /app/prisma/database.empty ./prisma/db/main.db | ||
|
|
||
| RUN chown -R twiggy:twiggy /app/prisma/db /app/assets/NFD/images |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I only want to have specific paths accessible for the twiggy user.
No description provided.