This repository has been archived by the owner on Jul 25, 2019. It is now read-only.
GA commands now prefix their command name with the name of the GA tracker #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cker to handle cases when developers assign specific names to their trackers
gvoss
reviewed
May 23, 2018
| if (window.ga && window.ga.getAll) { | ||
| trackers = ga.getAll(); | ||
| if (trackers.length > 0) { | ||
| return trackers[0].get('name'); |
There was a problem hiding this comment.
Curious if you know - why would there be more than one tracker and should we fire events to all trackers?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GA commands now prefix their command name with the name of the GA tracker to handle cases when developers assign specific names to their trackers.
This branch is being used live at https://www.lonelyplanet.com/italy (Notice the video poster with the play button on it midway down the page -- it may take a moment to load after the page loads depending on your internet connection)
In the javascript console, notice that the following command doesn't work (Please don't run, or be careful as this is live GA data we're mucking with here):
ga("send", "pageview");But this one will work because when we run ga("create", ..) earlier on, we assign a special tracker name to the object:
ga("tealium_0.send", "pageview");