Add support to scheduler message #3487

lillo42 · 2025-01-20T14:56:37Z

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.02 (8.17 -> 8.15)

Declining Code Health: 4 findings(s) 🚩
Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.02 (8.17 -> 8.15)

Declining Code Health: 4 findings(s) 🚩
Affected Hotspots: 2 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.16 (8.69 -> 8.53)

Declining Code Health: 12 findings(s) 🚩
Improving Code Health: 2 findings(s) ✅
Affected Hotspots: 7 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis · 2025-02-04T14:15:40Z

src/Paramore.Brighter/OutboxProducerMediator.cs

@@ -31,6 +31,7 @@ THE SOFTWARE. */
 using Microsoft.Extensions.Logging;
 using Paramore.Brighter.Logging;
 using Paramore.Brighter.Observability;
+using Paramore.Brighter.Scheduler.Events;


❌ Getting worse: Code Duplication
introduced similar code in: CreateMessageFromRequest,CreateMessageFromRequestAsync

_Suppress

codescene-delta-analysis · 2025-02-04T14:15:41Z

src/Paramore.Brighter.MessagingGateway.Kafka/KafkaMessageProducer.cs

@@ -27,6 +27,7 @@ THE SOFTWARE. */
 using System.Threading.Tasks;
 using Confluent.Kafka;
 using Microsoft.Extensions.Logging;
+using Paramore.Brighter.Tasks;


✅ Getting better: Code Duplication
reduced similar code in: Send,SendAsync

codescene-delta-analysis · 2025-02-04T14:15:44Z

src/Paramore.Brighter.MessagingGateway.MsSql/MsSqlMessageProducer.cs

+        { 
+            delay ??= TimeSpan.Zero;
+            if (delay != TimeSpan.Zero)
+            {
+                if (Scheduler is IAmAMessageSchedulerSync sync)
+                {
+                    sync.Schedule(message, delay.Value);
+                    return;
+                }
+
+                if (Scheduler is IAmAMessageSchedulerAsync async)
+                {
+                    BrighterAsyncContext.Run(async () => await async.ScheduleAsync(message, delay.Value));
+                    return;
+                } 
+
+                s_logger.LogWarning("MsSqlMessageProducer: no scheduler configured, message will be sent immediately");
+            }
+
+            var topic = message.Header.Topic;
+
+            s_logger.LogDebug("MsSqlMessageProducer: send message with topic {Topic} and id {Id}", topic, message.Id);
+
+            _sqlQ.Send(message, topic);


❌ New issue: Code Duplication
The module contains 2 functions with similar structure: SendWithDelay,SendWithDelayAsync

_Suppress

src/Paramore.Brighter.MessagingGateway.Redis/RedisMessageProducer.cs

codescene-delta-analysis · 2025-02-04T14:15:47Z

src/Paramore.Brighter/Observability/BrighterSpanExtensions.cs

@@ -42,6 +42,7 @@ public static class BrighterSpanExtensions
       CommandProcessorSpanOperation.Send => "send",
       CommandProcessorSpanOperation.Clear => "clear",
       CommandProcessorSpanOperation.Archive => "archive",
+       CommandProcessorSpanOperation.Scheduler => "scheduler",


❌ Getting worse: Complex Method
ToSpanName increases in cyclomatic complexity from 9 to 10, threshold = 9

_Suppress

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.16 (8.69 -> 8.53)

Declining Code Health: 12 findings(s) 🚩
Improving Code Health: 2 findings(s) ✅
Affected Hotspots: 7 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.15 (8.69 -> 8.54)

Declining Code Health: 13 findings(s) 🚩
Improving Code Health: 2 findings(s) ✅
Affected Hotspots: 7 files(s) 🔥

View detailed results in CodeScene

codescene-delta-analysis

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.15 (8.69 -> 8.54)

Declining Code Health: 13 findings(s) 🚩
Improving Code Health: 2 findings(s) ✅
Affected Hotspots: 7 files(s) 🔥

View detailed results in CodeScene

iancooper

First, there is a tremendous amount of work here, that has broken the back of this. So thank you so much. I think my thoughts are generally:

Let's overload existing methods to take a DateTimeOffset scheduledAt parameter (and provide a helper method to create a scheduledAt from a TimeSpan that represents a delay) over new method names
We have different job types: Request (from CP goes back to send, post or publish, you need to know which) and Message (from a consumer implementation, used to delay posting a message, comes back to the consumer )
That makes your scheduler a bit more gnarly; you want an interface that the 3rd party lib support implements that offers either.

But once we have that this will solve a massive problem for us with supporting a Send at a point in time, which will be a really powerful addition in V10

iancooper · 2025-02-05T10:09:27Z

docs/adr/0024-Scheduling.md

+```c#
+public interface IAmACommandProcessor
+{
+    string SchedulerSend<TRequest>(TimeSpan delay, TRequest request) where TRequest : class, IRequest;


I wonder if we would be better off overloading Send with a time, than adding a new name here

Alternatively, how about SendAt, PublishAt, PostAt etc.

src/Paramore.Brighter.MessagingGateway.AWSSQS/SnsMessageProducer.cs

iancooper · 2025-02-05T10:15:34Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SnsMessageProducer.cs

+
+            if (Scheduler is IAmAMessageSchedulerSync sync)
+            {
+                sync.Schedule(message, delay.Value);


Probably have to rename to strategy used above

iancooper · 2025-02-05T10:17:38Z

src/Paramore.Brighter.MessagingGateway.AWSSQS/SnsMessageProducer.cs

+                return;
+            }
+
+            if (Scheduler is IAmAMessageSchedulerSync sync)


Should we assume that an async path, always has an async scheduler, and only use the sync scheduler on a sync path (or if transport does not support sync and async, just resort to whichever matches? This allows us to make a blocking decision via the Brighter Sync Context

src/Paramore.Brighter.MessagingGateway.AWSSQS/SqsMessageProducer.cs

iancooper · 2025-02-05T10:35:49Z

src/Paramore.Brighter/CommandProcessor.cs

+            }
+        }
+
+        public async Task<string> SchedulerPostAsync<TRequest>(TRequest request, 


The same comments apply. Overload with an At parameter over a new method convention; only one scheduler type

src/Paramore.Brighter/InMemoryMessageScheduler.cs

iancooper · 2025-02-05T10:37:31Z

src/Paramore.Brighter/InMemoryMessageScheduler.cs

+    }
+
+    /// <inheritdoc cref="Dispose"/>
+    public void Dispose()


Do we need to ensure we dispose any remaining timers here?

iancooper · 2025-02-05T10:40:19Z

src/Paramore.Brighter.MessageScheduler.Quartz/QuartzBrighterJob.cs

+        var message = JsonSerializer.Deserialize<Message>(obj!, JsonSerialisationOptions.Options)!;
+        if (async)
+        {
+            await processor.PostAsync(new FireSchedulerMessage { Id = id, Message = message });


This works if our intent is always to send a message, but on a Send or Publish intent is actually just to delay Send or Publish.

iancooper · 2025-02-05T10:41:47Z

src/Paramore.Brighter.MessagingGateway.Redis/RedisMessageProducer.cs

+            delay ??= TimeSpan.Zero;
+            if (delay != TimeSpan.Zero)
+            {
+                if (Scheduler is IAmAMessageSchedulerAsync async)


usual comments on name and pick one

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (5 hotspots with Code Duplication, Complex Method, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (11 files with Code Duplication, Complex Method, Large Method, Excess Number of Function Arguments)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
RmqMessageProducer.cs	1 rule in this hotspot	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 rule in this hotspot	8.56 → 9.06	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
RmqMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 advisory rule	8.56 → 9.06	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.06	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-02-14T16:01:51Z

src/Paramore.Brighter/CommandProcessor.cs

@@ -37,6 +37,7 @@ THE SOFTWARE. */
 using Paramore.Brighter.FeatureSwitch;
 using Paramore.Brighter.Logging;
 using Paramore.Brighter.Observability;
+using Paramore.Brighter.Tasks;


❌ Getting worse: Code Duplication
introduced similar code in: Post,Post,PostAsync,PostAsync and 4 more functions

_Suppress

codescene-delta-analysis · 2025-02-14T16:01:51Z

src/Paramore.Brighter.Extensions.DependencyInjection/ServiceCollectionExtensions.cs

@@ -24,6 +24,7 @@ THE SOFTWARE. */
 #endregion

 using System;
+using System.Linq;


✅ No longer an issue: Code Duplication
The module no longer contains too many functions with similar structure

codescene-delta-analysis · 2025-02-14T16:01:52Z

src/Paramore.Brighter.ServiceActivator/ControlBus/ControlBusReceiverBuilder.cs

@@ -178,6 +178,7 @@ public Dispatcher Build(string hostName)
                .ExternalBus(ExternalBusType.FireAndForget, mediator)
                .ConfigureInstrumentation(null, InstrumentationOptions.None)
                .RequestContextFactory(new InMemoryRequestContextFactory())
+                .RequestSchedulerFactory(new InMemorySchedulerFactory())


❌ Getting worse: Large Method
Build increases from 73 to 74 lines of code, threshold = 70

_Suppress

codescene-delta-analysis · 2025-02-14T16:01:52Z

src/Paramore.Brighter.MessagingGateway.Kafka/KafkaMessageProducer.cs

+        public void SendWithDelay(Message message, TimeSpan? delay = null)
+        {
+            delay ??= TimeSpan.Zero;
+            if (delay != TimeSpan.Zero)
+            {
+                var schedulerSync = (IAmAMessageSchedulerSync)Scheduler!;
+                schedulerSync.Schedule(message, delay.Value);
+                return;
+            }
+


❌ New issue: Complex Method
SendWithDelay has a cyclomatic complexity of 10, threshold = 9

_Suppress

codescene-delta-analysis · 2025-02-14T16:01:53Z

src/Paramore.Brighter.MessageScheduler.Aws/AwsScheduler.cs

+    private async Task<string> ScheduleAsync(
+        Message message,
+        string id,
+        DateTimeOffset at,
+        bool async,
+        CancellationToken cancellationToken = default)
+    {
+        await EnsureGroupExistsAsync(cancellationToken);
+        var target = await CreateTargetAsync(id, message, async);
+
+        using var client = factory.CreateSchedulerClient();
+        try
+        {
+            await client.CreateScheduleAsync(
+                new CreateScheduleRequest
+                {
+                    Name = id,
+                    GroupName = schedulerGroup.Name,
+                    Target = target,
+                    ScheduleExpression = AtExpression(at),
+                    ScheduleExpressionTimezone = "UTC",
+                    State = ScheduleState.ENABLED,
+                    ActionAfterCompletion = ActionAfterCompletion.DELETE,
+                    FlexibleTimeWindow = scheduler.ToFlexibleTimeWindow()
+                }, cancellationToken);
+        }
+        catch (ConflictException)
+        {
+            if (scheduler.OnConflict == OnSchedulerConflict.Throw)
+            {
+                throw;
+            }
+
+            await client.UpdateScheduleAsync(
+                new UpdateScheduleRequest
+                {
+                    Name = id,
+                    GroupName = schedulerGroup.Name,
+                    Target = target,
+                    ScheduleExpression = AtExpression(at),
+                    ScheduleExpressionTimezone = "UTC",
+                    State = ScheduleState.ENABLED,
+                    ActionAfterCompletion = ActionAfterCompletion.DELETE,
+                    FlexibleTimeWindow = scheduler.ToFlexibleTimeWindow()
+                }, cancellationToken);
+        }
+
+        return id;
+    }


❌ New issue: Excess Number of Function Arguments
ScheduleAsync has 5 arguments, threshold = 4

_Suppress

codescene-delta-analysis · 2025-02-14T16:01:53Z

src/Paramore.Brighter.MessageScheduler.Quartz/QuartzScheduler.cs

+    public string Schedule(Message message, DateTimeOffset at)
+    {
+        var id = getOrCreateMessageSchedulerId(message);
+        var job = JobBuilder.Create<QuartzBrighterJob>()
+            .WithIdentity(id, group!)
+            .UsingJobData("message", JsonSerializer.Serialize(
+                new FireSchedulerMessage { Id = id, Async = false, Message = message },
+                JsonSerialisationOptions.Options))
+            .Build();
+
+        var trigger = TriggerBuilder.Create()
+            .WithIdentity(id + "-trigger", group!)
+            .StartAt(at)
+            .Build();
+
+        BrighterAsyncContext.Run(async () => await scheduler.ScheduleJob(job, trigger));
+        return id;
+    }


❌ New issue: Code Duplication
The module contains 4 functions with similar structure: Schedule,Schedule,ScheduleAsync,ScheduleAsync

_Suppress

codescene-delta-analysis · 2025-02-14T16:01:54Z

src/Paramore.Brighter/InMemoryScheduler.cs

+    private static void Execute(object? state)
+    {
+        // .NET Standard doesn't support if(state is (IAmACommandProcessor, FireSchedulerMessage))
+        var fireMessage = state as (IAmACommandProcessor, FireSchedulerMessage)?;
+        if (fireMessage != null)
+        {
+            var (processor, message) = (fireMessage.Value.Item1, fireMessage.Value.Item2);
+            BrighterAsyncContext.Run(async () => await processor.SendAsync(message));
+
+            if (s_timers.TryRemove(message.Id, out var timer))
+            {
+                timer.Dispose();
+            }
+
+            return;
+        }
+
+        var fireRequest = state as (IAmACommandProcessor, FireSchedulerRequest)?;
+        if (fireRequest != null)
+        {
+            var (processor, request) = (fireRequest.Value.Item1, fireRequest.Value.Item2);
+            BrighterAsyncContext.Run(async () => await processor.SendAsync(request));
+
+            if (s_timers.TryRemove(request.Id, out var timer))
+            {
+                timer.Dispose();
+            }
+
+            return;
+        }
+
+        Logger.LogError("Invalid input during executing scheduler {Data}", state);
+    }


❌ New issue: Bumpy Road Ahead
Execute has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

_Suppress

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (5 hotspots with Code Duplication, Complex Method, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (11 files with Code Duplication, Complex Method, Large Method, Excess Number of Function Arguments)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
RmqMessageProducer.cs	1 rule in this hotspot	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 rule in this hotspot	8.56 → 9.06	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
RmqMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 advisory rule	8.56 → 9.06	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.06	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (4 hotspots with Code Duplication, Complex Method, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (10 files with Code Duplication, Complex Method, Large Method, Excess Number of Function Arguments)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 rule in this hotspot	8.56 → 9.06	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 advisory rule	8.56 → 9.06	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.06	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (4 hotspots with Code Duplication, Complex Method, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (12 files with Code Duplication, Complex Method, Large Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 rule in this hotspot	8.56 → 9.06	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress
ServiceCollectionExtensions.cs	1 advisory rule	8.56 → 9.06	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.06	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-02-17T14:48:24Z

src/Paramore.Brighter/Scheduler/Handlers/FireSchedulerRequestHandler.cs

+    private async Task ExecuteAsync<T>(FireSchedulerRequest command, CancellationToken cancellationToken = default)
+        where T : class, IRequest
+    {
+        var request = JsonSerializer.Deserialize<T>(command.RequestData, JsonSerialisationOptions.Options)!;
+        if (command is { SchedulerType: RequestSchedulerType.Send, Async: true })
+        {
+            await processor.SendAsync(request, cancellationToken: cancellationToken);
+        }
+        else if (command.SchedulerType == RequestSchedulerType.Send)
+        {
+            processor.Send(request);
+        }
+        else if (command is { SchedulerType: RequestSchedulerType.Publish, Async: true })
+        {
+            await processor.PublishAsync(request, cancellationToken: cancellationToken);
+        }
+        else if (command.SchedulerType == RequestSchedulerType.Publish)
+        {
+            processor.Publish(request);
+        }
+        else if (command is { SchedulerType: RequestSchedulerType.Post, Async: true })
+        {
+            await processor.PostAsync(request, cancellationToken: cancellationToken);
+        }
+        else if (command.SchedulerType == RequestSchedulerType.Post)
+        {
+            processor.Post(request);
+        }
+    }


❌ New issue: Bumpy Road Ahead
ExecuteAsync has 5 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function

_Suppress

codescene-delta-analysis · 2025-02-17T14:48:24Z

src/Paramore.Brighter/InMemoryScheduler.cs

+    public string Schedule(Message message, TimeSpan delay)
+    {
+        var id = getOrCreateMessageSchedulerId(message);
+        if (s_timers.TryGetValue(id, out var timer))
+        {
+            if (onConflict == OnSchedulerConflict.Throw)
+            {
+                throw new InvalidOperationException($"scheduler with '{id}' id already exists");
+            }
+
+            timer.Dispose();
+        }
+
+        s_timers[id] = timeProvider.CreateTimer(Execute, (processor, new FireSchedulerMessage
+        {
+            Id = id,
+            Async = false,
+            Message = message
+        }), delay, TimeSpan.Zero);
+        return id;
+    }


❌ New issue: Code Duplication
The module contains 4 functions with similar structure: Schedule,Schedule,ScheduleAsync,ScheduleAsync

_Suppress

codescene-delta-analysis · 2025-02-17T14:48:24Z

src/Paramore.Brighter.MessagingGateway.RMQ.Sync/RmqMessageProducer.cs

-                        Task.Delay(delay.Value).Wait();
-                        rmqMessagePublisher.PublishMessage(message, TimeSpan.Zero);
-                    }
+                     if (delay == TimeSpan.Zero || DelaySupported || Scheduler == null)


❌ New issue: Complex Conditional
SendWithDelay has 1 complex conditionals with 2 branches, threshold = 2

_Suppress

codescene-delta-analysis · 2025-02-17T14:48:25Z

src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessageProducer.cs

    public async Task SendWithDelayAsync(Message message, TimeSpan? delay, CancellationToken cancellationToken = default)
+        => await SendWithDelayAsync(message, delay, true, cancellationToken);
+
+    private async Task SendWithDelayAsync(Message message, TimeSpan? delay, bool useSchedulerAsync, CancellationToken cancellationToken = default)


❌ New issue: Complex Method
SendWithDelayAsync has a cyclomatic complexity of 10, threshold = 9

_Suppress

codescene-delta-analysis · 2025-02-17T14:48:25Z

src/Paramore.Brighter.MessagingGateway.RMQ.Async/RmqMessageProducer.cs

@@ -144,14 +153,19 @@ public async Task SendWithDelayAsync(Message message, TimeSpan? delay, Cancellat

            _pendingConfirmations.TryAdd(await Channel.GetNextPublishSequenceNumberAsync(cancellationToken), message.Id);

-            if (DelaySupported)
+            if (delay == TimeSpan.Zero || DelaySupported || Scheduler == null)


❌ New issue: Complex Conditional
SendWithDelayAsync has 1 complex conditionals with 2 branches, threshold = 2

_Suppress

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (3 hotspots with Code Duplication, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (11 files with Code Duplication, Large Method, Complex Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.11	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (3 hotspots with Code Duplication, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (12 files with Code Duplication, Large Method, Complex Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AzureServiceBusScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.11	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (3 hotspots with Code Duplication, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (12 files with Code Duplication, Large Method, Complex Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AzureServiceBusScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.11	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis · 2025-02-18T10:10:36Z

src/Paramore.Brighter.MessageScheduler.Azure/AzureServiceBusScheduler.cs

+    public async Task<string> ScheduleAsync(Message message, DateTimeOffset at,
+        CancellationToken cancellationToken = default)
+    {
+        var seq = await sender.ScheduleMessageAsync(
+            ConvertToServiceBusMessage(new Message
+            {
+                Header =
+                    new MessageHeader(message.Id, schedulerTopic, MessageType.MT_EVENT,
+                        subject: nameof(FireAzureScheduler)),
+                Body = new MessageBody(JsonSerializer.Serialize(
+                    new FireAzureScheduler { Id = message.Id, Async = true, Message = message },
+                    JsonSerialisationOptions.Options))
+            }), at, cancellationToken);
+
+        return seq.ToString();
+    }


❌ New issue: Code Duplication
The module contains 4 functions with similar structure: Schedule,Schedule,ScheduleAsync,ScheduleAsync

_Suppress

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (3 hotspots with Code Duplication, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (12 files with Code Duplication, Large Method, Complex Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AzureServiceBusScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.11	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

codescene-delta-analysis

Code Health Improved (1 files improve in Code Health)

Gates Failed
Prevent hotspot decline (3 hotspots with Code Duplication, Large Method)
Enforce critical code health rules (2 files with Bumpy Road Ahead)
Enforce advisory code health rules (12 files with Code Duplication, Large Method, Complex Method, Excess Number of Function Arguments, Complex Conditional)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure

Prevent hotspot decline	Violations	Code Health Impact
CommandProcessor.cs	1 rule in this hotspot	8.28 → 7.33	Suppress
OutboxProducerMediator.cs	1 rule in this hotspot	7.38 → 7.16	Suppress
ControlBusReceiverBuilder.cs	1 rule in this hotspot	8.46 → 8.46	Suppress

Enforce critical code health rules	Violations	Code Health Impact
InMemoryScheduler.cs	1 critical rule	10.00 → 9.24	Suppress
FireSchedulerRequestHandler.cs	1 critical rule	10.00 → 9.39	Suppress

Enforce advisory code health rules	Violations	Code Health Impact
CommandProcessor.cs	1 advisory rule	8.28 → 7.33	Suppress
InMemoryScheduler.cs	1 advisory rule	10.00 → 9.24	Suppress
MsSqlMessageProducer.cs	1 advisory rule	10.00 → 9.39	Suppress
QuartzScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
AzureServiceBusScheduler.cs	1 advisory rule	10.00 → 9.39	Suppress
RmqMessageProducer.cs	2 advisory rules	9.39 → 8.82	Suppress
AwsScheduler.cs	1 advisory rule	10.00 → 9.69	Suppress
RmqMessageProducer.cs	1 advisory rule	9.69 → 9.39	Suppress
KafkaMessageProducer.cs	1 advisory rule	9.39 → 9.10	Suppress
OutboxProducerMediator.cs	1 advisory rule	7.38 → 7.16	Suppress
BrighterSpanExtensions.cs	1 advisory rule	9.50 → 9.47	Suppress
ControlBusReceiverBuilder.cs	1 advisory rule	8.46 → 8.46	Suppress

View Improvements

File	Code Health Impact	Categories Improved
ServiceCollectionExtensions.cs	8.56 → 9.11	Code Duplication
KafkaMessageProducer.cs	9.39 → 9.10	Code Duplication
RedisMessageProducer.cs	no change	Code Duplication

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

iancooper · 2025-02-18T17:04:31Z

Thanks for getting spans in; that really helps!!
Thanks for adding the overloads with the offset; having both at and delay overloads makes sense
Generally, all public methods should have XML comments. Feel free to make classes internal, where they are not exposed (for consumption or tests). You can use to indicate types in params and return values; use remarks if there is something interesting. We may document an implementation if it has details that are class-specific, not interface-specific.
Let's chat about the design decision to have a FireScheduleRequest being Sent to the CP and then the correct CP method being invoked in the hand. You might be trying to align the message and request call-back paths. I guess the trade-off is between one pattern, and a cheaper request implementation. Might be worth updating our ADR for why.

lillo42 added 6 commits January 17, 2025 15:15

Init Message Scheduler V1

44af426

Init support to scheduler messages

b8d365b

Improve scheduler

6ddfa0c

Improve scheduler

8fa4a58

Add ADR

0c54163

rollback unnecessary changes

42b904c

codescene-delta-analysis bot reviewed Jan 20, 2025

View reviewed changes

Merge branch 'master' into message-scheduler-v1

69d2871

codescene-delta-analysis bot reviewed Jan 20, 2025

View reviewed changes

iancooper assigned lillo42 Jan 22, 2025

iancooper added 2 - In Progress grabbed by assignee feature request .NET Pull requests that update .net code Draft This is a work in progress labels Jan 22, 2025

lillo42 added 4 commits February 3, 2025 17:00

Improve Scheduler support

b377821

Improve scheduler messages

3cfa7f3

Fixes unit tests

cd0ec7f

Add Unit test

aff9240

codescene-delta-analysis bot reviewed Feb 4, 2025

View reviewed changes

Merge branch 'master' into message-scheduler-v1

172f9c2

codescene-delta-analysis bot reviewed Feb 4, 2025

View reviewed changes

Remove Hangfire and add Quartz

0bed01e

codescene-delta-analysis bot reviewed Feb 4, 2025

View reviewed changes

lillo42 added 2 commits February 5, 2025 08:56

Fixes unit test

a6abc68

Quartz Add support to .NET Standard & .NET 9.0

c266d09

codescene-delta-analysis bot reviewed Feb 5, 2025

View reviewed changes

iancooper reviewed Feb 5, 2025

View reviewed changes

lillo42 added 2 commits February 6, 2025 08:33

Add AWS Scheduler

6340079

Add Missing file

dad21ca

lillo42 added 2 commits February 14, 2025 15:45

fixes sample

db8625c

Fixes unit tests

63a228a

codescene-delta-analysis bot reviewed Feb 14, 2025

View reviewed changes

Merge branch 'master' into message-scheduler-v1

be53190

codescene-delta-analysis bot reviewed Feb 14, 2025

View reviewed changes

lillo42 added 3 commits February 17, 2025 10:54

Fixes build

e6498da

Merge master with

536af61

Fix build

2999fc4

codescene-delta-analysis bot reviewed Feb 17, 2025

View reviewed changes

fixes unit tests

c417c85

codescene-delta-analysis bot reviewed Feb 17, 2025

View reviewed changes

fixes unit tests

106a79d

codescene-delta-analysis bot reviewed Feb 17, 2025

View reviewed changes

lillo42 marked this pull request as ready for review February 17, 2025 15:29

lillo42 requested review from holytshirt, DevJonny and preardon as code owners February 17, 2025 15:29

Add support to Azure

4faf2b4

codescene-delta-analysis bot reviewed Feb 17, 2025

View reviewed changes

lillo42 added 5 commits February 18, 2025 09:09

Merge with master

d824838

fixes Azure & AWS scheduler

a7248ee

Merge branch 'master' into message-scheduler-v1

3aa2bc5

Fixes var

245b5f8

Improve Azure service bus scheduler

db0792b

codescene-delta-analysis bot reviewed Feb 18, 2025

View reviewed changes

Merge branch 'master' into message-scheduler-v1

362bfd6

codescene-delta-analysis bot reviewed Feb 18, 2025

View reviewed changes

Merge branch 'master' into message-scheduler-v1

79ad345

codescene-delta-analysis bot reviewed Feb 18, 2025

View reviewed changes

Add support to scheduler message #3487

Are you sure you want to change the base?

Add support to scheduler message #3487

Conversation

lillo42 commented Jan 20, 2025 • edited Loading

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 4, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 4, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 4, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 4, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

iancooper left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 14, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 17, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 17, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 17, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 17, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 17, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot Feb 18, 2025

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

iancooper commented Feb 18, 2025

lillo42 commented Jan 20, 2025 •

edited

Loading