feat: create notification component #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wermeson-lopes-brisa
commented
Feb 2, 2024
wermeson-lopes-brisa
commented
wermeson-lopes-brisa
requested review from
iurynogueira,
deeved-hiuston-brisa,
alysson-mascarenhas-brisa and
allan-chagas-brisa
…tification-component
…tification-component
|
The lint broke due to an issue that has already been resolved in another PR (#67). |
…tification-component
…tification-component
…tification-component
danilo-moreira-brisa
removed the request for review
from alysson-mascarenhas-brisa
danilo-moreira-brisa
requested review from
pedro-martins-brisa and
marcos-assis-brisa
|
I refactored the work in progress to use signals. |
| @@ -0,0 +1,4 @@ | |||
| export * from './component/notification.component'; | |||
| export * from './mock/open-notification-mock.component'; | |||
There was a problem hiding this comment.
Should the mock really be exported to the public api?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.