Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove demo blocks #12

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Remove demo blocks #12

merged 1 commit into from
Feb 16, 2024

Conversation

JohnCoene
Copy link
Member

@JohnCoene JohnCoene commented Feb 16, 2024 •
edited
Loading

Removes demo blocks

@JohnCoene JohnCoene self-assigned this Feb 16, 2024
DivadNojnarg
DivadNojnarg reviewed Feb 16, 2024
View reviewed changes
Copy link
Contributor

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to remove all the code? I won't advise to build a plot like we did before so there're chances we'll never reuse this code.

@JohnCoene
Copy link
Member Author

This PR removes all the code already as far as I can tell, anything I missed?

DivadNojnarg
DivadNojnarg approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it was not shown in the diff.

@DivadNojnarg DivadNojnarg merged commit d3a6871 into main Feb 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DivadNojnarg DivadNojnarg DivadNojnarg approved these changes

Assignees

@JohnCoene JohnCoene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnCoene @DivadNojnarg