Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent cyclic block updates #161

Closed
wants to merge 2 commits into from
Closed

Prevent cyclic block updates #161

wants to merge 2 commits into from

Conversation

nbenn
Copy link
Collaborator

@nbenn nbenn commented Jan 9, 2024

This is intended to fix #159.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d2cfcd) 79.40% compared to head (3ec14bd) 82.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   79.40%   82.53%   +3.13%     
==========================================
  Files          16       16              
  Lines        1704     1701       -3     
==========================================
+ Hits         1353     1404      +51     
+ Misses        351      297      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbenn
Copy link
Collaborator Author

nbenn commented Jan 9, 2024

@DivadNojnarg how does this look to you? I believe this removes some of the unneeded executions of our update routines. At least it solves the cyclic updates for me.

At the time when we added

https://github.com/blockr-org/blockr/blob/1c5c1c87e9d67323ddf383d612102c84486b90b7/R/server.R#L120-L127

I was under the impression that this would not incur a dependency on blk but now it seems to me that it does, which would be unwanted.

As part of this PR I would also address #162.

@nbenn
Copy link
Collaborator Author

nbenn commented Jan 9, 2024

Closed in favor of #146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block level update trigger
1 participant