Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating Steve's changes to match with users updated requirement #329

Closed
wants to merge 21 commits into from

Conversation

MCazaly
Copy link
Contributor

@MCazaly MCazaly commented Sep 24, 2021

UPDATE: I think there is a bug new ticket

Adding Steve's unpushed work.
ticket 327 for discussion.

AC:

  • Unit testing works

(NB we have breaking changes in Altimetry.py so are more interested in the new structure working)

@jpolton jpolton linked an issue Mar 28, 2022 that may be closed by this pull request
@jpolton jpolton requested review from davbyr and anwiseNOCL March 30, 2022 09:00
@jpolton jpolton marked this pull request as ready for review March 30, 2022 09:02
@jpolton jpolton linked an issue Apr 1, 2022 that may be closed by this pull request
@jpolton jpolton marked this pull request as draft April 2, 2022 09:15
@jpolton jpolton removed request for davbyr and anwiseNOCL April 2, 2022 09:16
@lukegorman lukegorman marked this pull request as ready for review June 16, 2022 10:34
@roje-bodc
Copy link
Collaborator

Me and @lukegorman Have merged develop into this feature branch to fix the merge conflicts. (Due to the restructuring of the package.)

@MCazaly MCazaly self-assigned this Jun 20, 2022
@thogar-computer thogar-computer changed the title Add Steve's changes updating Steve's changes to match with users updated requirement Jun 27, 2022
@MCazaly
Copy link
Contributor Author

MCazaly commented Sep 14, 2022

Replaced by #494.

@MCazaly MCazaly closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Issue with wrapped coordinates - stop here Merge new subsetting code into framework
4 participants