Cmems #430
Open
Cmems #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpolton
reviewed
Apr 10, 2022
| ################################################# | ||
| # calculate currents | ||
| ################################################# | ||
| current = abs(sci_uv.dataset.u_velocity) * abs(sci_uv.dataset.v_velocity) |
There was a problem hiding this comment.
current = abs( complex(u,v) )
or
current = sqrt(u^2 + v^2)
There was a problem hiding this comment.
ok, thanks. How does it work to upgrade comments? Do I need to change the file on the CMEMS branch and push the changes again, or can I change things directly within this pull request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two examples. the cmems_example_plot.py plot is literally just a script that reads in and plots a figure, the cmems_sril34_example_plot.py shows example of the comparison between cmems and sril34. This one does the interpolation.
(I can add a mask to make the SRIL34 land region of the plot prettier, but it's a relatively pointless extra file.)
The CMEMS files are cropped around Sril Lanka ( a bit sider than the sril34 domain), so they are very small now. The SRIL34 are cropped to 3 days.