Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/deprec warn #560

Merged
merged 8 commits into from
Sep 21, 2022
Merged

Feature/deprec warn #560

merged 8 commits into from
Sep 21, 2022

Conversation

jpolton
Copy link
Collaborator

@jpolton jpolton commented Sep 21, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):
    Resolving non-critical depreciation warnings

What is the current behavior?

Issue URL: #558

What is the new behavior?

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jpolton jpolton marked this pull request as ready for review September 21, 2022 14:05
@jpolton jpolton merged commit bfd047a into develop Sep 21, 2022
@jpolton jpolton deleted the feature/deprec_warn branch September 21, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants