remove deprec warning #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…phic-Data-Centre/COAsT into feature/deprec-warning
This was referenced Nov 8, 2023
THREESHOLD -> THESHOLD
jpolton
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good. I've restored a matplotlib thing whereby the color scale broke for one of the unit testing figures.
I'm not sure why the notebook_to_md tests are failing. I've been having a similar issue with bug/#628_cartopy_quivers. If we can fix it here then I'm pretty sure that the outstanding GitAction issues on PR will be solved to.
|
@jpolton , I fixed the cmap stuff and now it works. I also updated all github actions related to notebooks. An error occurred in the python version, as it was instantiated twice: in the workflow and in the environment.yml. So, I removed the workflow version for these tests. |
|
Great work. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the Python version, there were still some deprecation warnings present in the code. I successfully addressed and resolved all of the warnings associated with the COAsT code. However, there remain certain warnings related to the xarray and utide libraries, which cannot be eliminated since they pertain to dependencies. I also chose to retain one warning labeled as "Pending" because I believe it may only become relevant in the distant future.