-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0624/polar quivers notebook #650
Conversation
…raphic-Data-Centre/COAsT into 0624/polar_quivers_notebook
This plots the new dataset with contours that are tricky over the pole.
Moved plotting functions to plot_util and made units tests for them.
Hmmm. There is definitely a problem with installing cartopy on the GitAction runners. The problem looks like the containers are trying to install cartopy from source, which is hard. The internet recommends using conda to install cartopy. However, the runners use a |
Previously we installed cartopy but not pyproj. The problem now might be it is hard to mix these two packages as cartopy has pyproj under the hood... Maybe explicit use of pyproj can be avoided: https://clouds.eos.ubc.ca/~phil/courses/atsc301/html/cartopy_mapping_pyproj.html looks like it might be possible |
…nographic-Data-Centre/COAsT into 0624/polar_quivers_notebook
@jpolton @b-barton , I've made code updates by replacing cartopy with pyproj. Additionally, I've incorporated changes in the code to address pylint-related issues. All tests are passing, except for the pylint test. However, I've already addressed the pylint issue in a separate branch, which will resolve this issue. I also updated the example files and now they have only 5 mb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me
Pull request checklist
Please check if your PR fulfills the following requirements:
COAsT-site
repo, in a separate PR. See contributing to documentation for details../build.sh
) was run locally and no errors reported. NB not sure about this requirement: GitActions test thispylint .
) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this withblack
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #
What is the new behavior?
New example notebooks for the Arctic domain. This shows how to plot quivers and use the functions to make adjustments for NEMO curvilinear grid and cartopy polar projection. An additional notebook has been added for plotting the new example dataset (a cropped version of a global NEMO run) for the Arctic. This includes plotting contours over the arctic which are not straight forward. Additional plotting helper functions have been added to plot_util for making polar plots and for plotting contours on polar plots. Tests included for these.
Checklist
pip install . && pytest unit_testing/unit_test.py -s
)Same as before there are two tests I'm unable to run on my machine "test_gridded_initialisation" and "test_tidegauge_methods" (Windows things). The rest passed. I have no reason to think test_gridded_initialisation or test_tidegauge_methods would fail. Git actions tests keeps failing but I'm not sure why.
Does this introduce a breaking change?
Other information