Feature/msal #245
Open
Feature/msal #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Loos good as a first step. Would like to see the commented out code just be removed. This is what git is for. |
vyruz1986
reviewed
Feb 9, 2024
| @@ -158,7 +156,7 @@ export class AdminOverviewComponent implements OnInit, AfterViewInit { | |||
| }); | |||
| dialogRef.afterClosed().subscribe((isConfirmed: boolean) => { | |||
| if (isConfirmed) { | |||
| this.authService.requestPasswordReset(row.userId); | |||
| // this.authService.requestPasswordReset(row.userId); | |||
vyruz1986
reviewed
Feb 9, 2024
| @@ -180,7 +178,7 @@ export class LegalguardianOverviewComponent implements OnInit, AfterViewInit { | |||
| }); | |||
| dialogRef.afterClosed().subscribe((isConfirmed: boolean) => { | |||
| if (isConfirmed) { | |||
| this.authService.requestPasswordReset(row.userId); | |||
| // this.authService.requestPasswordReset(row.userId); | |||
vyruz1986
requested changes
Feb 9, 2024
Comment on lines
79
to
86
| // this.authService.isAdmin$.subscribe((res) => { | ||
| // this.isAdmin = res; | ||
| // this.updateRequirements(); | ||
| // }); | ||
| // this.authService.isAuthenticated$.subscribe((res) => { | ||
| // this.isAuthenticated = res; | ||
| // this.updateRequirements(); | ||
| // }); |
| @@ -15,7 +15,7 @@ const routes: Routes = [ | |||
| { | |||
| path: 'admin', | |||
| component: MainComponent, | |||
| canActivate: [AuthGuard], | |||
| canActivate: [], | |||
There was a problem hiding this comment.
Maybe add a todo to make sure we add a substitute here?
| b2cPolicyNames: IB2CPolicyNames; | ||
| } | ||
|
|
||
| export const endpoint = 'https://localhost:5001/'; |
There was a problem hiding this comment.
This ain't gonna work :|
.../app/modules/dashboard/components/registration-overview/registration-overview.component.html
Show resolved
Hide resolved
| @@ -30,15 +35,15 @@ | |||
| </mat-select> | |||
| </mat-form-field> | |||
| </div> | |||
| <div *ngIf="authService.isAdmin$ | async" class="careuser-filter"> | |||
There was a problem hiding this comment.
the authService.isAdmin$ condition should be left in place here
Comment on lines
38
to
43
| // TODO Reintroduce | ||
| //await Seed.SeedRolesAsync(serviceScope); | ||
| //await Seed.SeedUsersAsync(serviceScope, applicationDbContext, initialAdminPassword); | ||
| //await Seed.CheckRolesAsync(serviceScope, applicationDbContext); | ||
| //Seed.CreateAPIAndClient(configrationDbContext); | ||
| //Seed.SeedIdentityResources(configrationDbContext); |
There was a problem hiding this comment.
I think this can be removed. Our application shouldn't have to worry about seeding roles or users anymore. We just need to put the expected roles on the controllers
Singer.API/Program.cs
Outdated
|
|
||
|
|
||
| app.UseCors(builder => builder.AllowAnyOrigin().AllowAnyHeader().AllowAnyMethod()); | ||
| //app.UseIdentityServer(); |
| @@ -23,8 +20,8 @@ namespace Singer.Services; | |||
|
|
|||
| public class AdminUserService : UserService<AdminUser, AdminUserDTO, CreateAdminUserDTO, UpdateAdminUserDTO>, IAdminUserService | |||
There was a problem hiding this comment.
I think this whole service can be removed?
Singer.API/Services/UserService.cs
Outdated
Tests/TestData/BaseTest.cs
Outdated
| @@ -27,6 +27,6 @@ public virtual void Setup() | |||
| [TearDown] | |||
| public virtual void TearDown() | |||
| { | |||
| TestDataContext.Dispose(); | |||
| //TestDataContext.Dispose(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to MS Azure AD B2C
This is a very large PR.
Focus points
Additionals: