-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing Modular Architecture and Debugging in BrkRaw: Introduction of New API and App Modules #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 #146 #155
This pull request represents a significant milestone. It aims to:
Changes proposed in this pull request:
Introduced a new 'api' module with the following submodules: 'pvobj', 'analyzer', 'brkobj', 'helper':
<pvobj>.contents
and access files directly with<pvobj>.<filename>
. For example, after creating a PvScan instance namedscanobj
, you can directly access method parameters withscanobj.method["PVM_xxxx"]
. This functionality is dynamically linked to the files present in the contents (binary files such as fid, 2dseq will be returned as buffer IO).Introduced a new 'app' module, which is poised to become the main user interface including both GUI and CLI elements. The 'tonifti' module is currently under active development within 'app'. The app module will support plugins, enabling extensibility by users without affecting the core source code.
All Python files within these modules are maintained under 400 lines to enhance readability and maintainability. Each module has dedicated functions, and unit tests will be written to verify each module's functionality.
Please note that the current versions of the 'api' and 'app' modules do not yet support command-line interfaces (CLI), and the 'tonifti' method is still under development. To ensure continued functionality, the original 'lib' module and its scripts remain unchanged and will continue to be available. I anticipate deprecating the 'lib' module in version 0.5.0, once all original functionalities have been successfully rebuilt and integrated into the new modules.
@BrkRaw/Bruker