Skip to content

code for smart TV appium #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

code for smart TV appium #1

wants to merge 6 commits into from

Conversation

SiddhiRao10
Copy link
Collaborator

No description provided.

@SiddhiRao10 SiddhiRao10 self-assigned this Jun 11, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

SiddhiRao10 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 11, 2024
View reviewed changes
target/surefire-reports/index.html Outdated
<link type="text/css" href="testng-reports.css" rel="stylesheet" id="retro" disabled="false"/>
<script type="text/javascript" src="jquery-3.6.0.min.js"></script>
<script type="text/javascript" src="testng-reports.js"></script>
<script type="text/javascript" src="https://www.google.com/jsapi"></script>

Check warning

Code scanning / Semgrep OSS

Semgrep Finding: html.security.audit.missing-integrity.missing-integrity Warning

This tag is missing an 'integrity' subresource integrity attribute. The 'integrity' attribute allows for the browser to verify that externally hosted files (for example from a CDN) are delivered without unexpected manipulation. Without this attribute, if an attacker can modify the externally hosted resource, this could lead to XSS and other types of attacks. To prevent this, include the base64-encoded cryptographic hash of the resource (file) you’re telling the browser to fetch in the 'integrity' attribute for all externally hosted files.
@samirans89
Copy link

samirans89 commented Dec 23, 2024 •
edited
Loading

@SiddhiRao10 - Please remove .idea folder altogether.

@samirans89
Copy link

@SiddhiRao10 - same with logs folder. There is always a risk since the logs generated sometimes has sensitive data. In addition, there is no use of user specific log folder to exist in git

samirans89
samirans89 requested changes Dec 23, 2024
View reviewed changes
Copy link

@samirans89 samirans89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove .idea and logs folder, all .DS_Store files, surefire-reports, .class files

SiddhiRao10
SiddhiRao10 commented Dec 23, 2024
View reviewed changes
Copy link
Collaborator Author

@SiddhiRao10 SiddhiRao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samirans89 requested changes are completed in this commit.

@samirans89
Copy link

@SiddhiRao10 - Please remove the target directory and all instances of .DS_Store files.

SiddhiRao10
SiddhiRao10 commented Dec 23, 2024
View reviewed changes
Copy link
Collaborator Author

@SiddhiRao10 SiddhiRao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added .gitignore file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samirans89 samirans89 samirans89 requested changes

@princebaretto99 princebaretto99 Awaiting requested review from princebaretto99

Assignees

@SiddhiRao10 SiddhiRao10

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiddhiRao10 @CLAassistant @samirans89