Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal code review request #2

Merged
merged 19 commits into from
Nov 14, 2024
Merged

Internal code review request #2

merged 19 commits into from
Nov 14, 2024

Conversation

Randall-Scharpf
Copy link
Member

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this being done for a test? i went to compare to adafruit circuitpy 9.0.3 and it has the i2ctarget line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant code that never should have been there, and i was messing around with the compilation config for target modes and accidentally touched this one. I'll put this back to avoid the scrutiny and need to test on the other board, since it's relatively out of scope for these changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't want this to be merged to main

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove in merge commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to merge our custom build scripts to main? we don't want to merge it to adafruit, and we aren't even using it anymore

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove in merge commit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same comment as mac script, also should remove the "build-samd51-interpreter" and "build-samd51-interpreter-mac" scripts on main)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove in merge commit

ports/atmel-samd/common-hal/busio/SPI.c Show resolved Hide resolved

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still says I2C

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still says I2C

@Randall-Scharpf Randall-Scharpf merged commit 821b7f2 into main Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants