-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS console log support #15402
Merged
Merged
JS console log support #15402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into feature/js-logging
…basic test cases.
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…o feature/js-logging
…sting backend JS or frontend.
adrinr
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Great work @mike12345567 . There are two arrows at the right of the screenshot that seem to be out of place. |
adrinr
approved these changes
Jan 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for
console.log
type functions when writing JS bindings. These will be presented as part of the preview - displayed as such:error state:
This will correctly handle
warn
anderror
- creating a visual distinction from other log types. This will also handle comma separated log statements and will correctly display different types (e.g. correctly highlighting JSON).All logging is handled purely in the frontend, so while you can preview them for formulas or automation bindings (when preview is supported) they will not be logged on the backend currently.
Logs in the design section will carry through to the app currently, so that when previewing a real page you can check how bindings are evaluating (say in the preview of the app).
Note: At the moment
.table()
is supported, but does not get displayed any differently to a log statement (it is not fully supported currently).