-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show screens that are linked to the selected query #15487
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one small thing we can remove.
Right = "right", | ||
LeftOutside = "left-outside", | ||
RightOutside = "right-outside", | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PopoverAlignment
already is an enum exported from BBUI - so you can resue that instead of adding this! 👌
Description
Adds a button in both the datasource / rest query screens that shows the user how many screens are linked to this particular query.
Uses the same component as the grid button that so look / usage is the same.
Screenshots
If a UI facing feature, a short video of the happy path, and some screenshots of the new functionality.
Addresses
Launchcontrol