Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show screens that are linked to the selected query #15487

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

PClmnt
Copy link
Collaborator

@PClmnt PClmnt commented Feb 5, 2025

Description

Adds a button in both the datasource / rest query screens that shows the user how many screens are linked to this particular query.

Uses the same component as the grid button that so look / usage is the same.

Screenshots

If a UI facing feature, a short video of the happy path, and some screenshots of the new functionality.

image image

Addresses

Launchcontrol

  • Added a button/ popover to both the Datasource and REST Query screens displaying the number of screens linked to the respective query

Copy link

qa-wolf bot commented Feb 5, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one small thing we can remove.

Right = "right",
LeftOutside = "left-outside",
RightOutside = "right-outside",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PopoverAlignment already is an enum exported from BBUI - so you can resue that instead of adding this! 👌

Base automatically changed from feature/pre-empt-data-source-deletion to master February 7, 2025 13:02
@PClmnt PClmnt marked this pull request as ready for review February 7, 2025 15:06
@github-actions github-actions bot added the size/m label Feb 7, 2025
@PClmnt PClmnt merged commit 73de5ad into master Feb 7, 2025
20 checks passed
@PClmnt PClmnt deleted the feature/screen-query-usage-ui branch February 7, 2025 22:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants