Data section resource deletion warning #15499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-empt-data-source-deletion
…e-empt-data-source-deletion
…e-empt-data-source-deletion
…e-empt-data-source-deletion
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
samwho
reviewed
Feb 6, 2025
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Outdated
Show resolved
Hide resolved
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Show resolved
Hide resolved
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Outdated
Show resolved
Hide resolved
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Show resolved
Hide resolved
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Show resolved
Hide resolved
…dibase/budibase into feature/pre-empt-data-source-deletion
samwho
reviewed
Feb 6, 2025
packages/builder/src/components/backend/modals/DeleteDataConfirmationModal.svelte
Outdated
Show resolved
Hide resolved
…dibase/budibase into feature/pre-empt-data-source-deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we had some warnings for deletion of data resources - but they were not always accurate and did not cover all of the data resources that are available within the system.
We have implemented a new endpoint
POST /api/screens/usage/:sourceIdthat will determine what type of data resource the source is and then attempt to find its usages throughout the screens within the app - this can then be used to warn users before deleting a data resource that it may break the screen to remove it.Screenshots
A query, not in use:
A query that is in use:
A datasource which is in use (through queries) and has two queries attached to it:
An internal table, with views, that is in use:
An external table, with views, but no screens:
An external table, with no views and no screens:
A view used in screens:
