Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clickoutside on firefox #15517

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Feb 10, 2025

Description

Follow up on #15483. That does not work for firefox, as body is marked as activeElement instead of iframe.

Copy link

linear bot commented Feb 10, 2025

Copy link

qa-wolf bot commented Feb 10, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@adrinr adrinr changed the title Budi 9016/fix clickoutside on firefox Fix clickoutside on firefox Feb 10, 2025
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/xs labels Feb 10, 2025
@adrinr adrinr requested a review from aptkingston February 10, 2025 18:14
@adrinr adrinr marked this pull request as ready for review February 10, 2025 18:14
@adrinr adrinr enabled auto-merge February 11, 2025 12:04
@adrinr adrinr merged commit 72f8a3f into master Feb 11, 2025
20 checks passed
@adrinr adrinr deleted the BUDI-9016/fix-clickoutside-on-firefox branch February 11, 2025 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firestorm Data/Infra/Revenue Team size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants