fix: dylib parsing

BugSplat-Git · Oct 1, 2024 · 07013f7 · 07013f7
1 parent 339b76e
commit 07013f7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/spec/factory.spec.ts b/spec/factory.spec.ts
@@ -82,4 +82,25 @@ describe('createMachoFiles', () => {
             expect(expected.get(uuid)).toEqual(path);
         }
     });
+
+  describe("isFatOrMacho", () => {
+    it("should return true for fat file", async () =>
+      expectAsync(
+        isFatOrMacho(
+          "spec/support/bugsplat-ios.app/Frameworks/bugsplat.framework/HockeySDKResources.bundle/Contents/MacOS/HockeySDKResources"
+        )
+      ).toBeResolvedTo(true));
+
+    it("should return true for macho file", async () =>
+      expectAsync(
+        isFatOrMacho(
+          "spec/support/bugsplat.app.dSYM/Contents/Resources/DWARF/bugsplat"
+        )
+      ).toBeResolvedTo(true));
+
+    it("should return true for dylib file", async () =>
+      expectAsync(isFatOrMacho("spec/support/libggcurl.dylib")).toBeResolvedTo(
+        true
+      ));
+  });
 });
diff --git a/src/factory.ts b/src/factory.ts
@@ -93,6 +93,6 @@ async function getUniqueMachoFiles(machoFiles: Array<MachoFile>): Promise<Array<
     return Array.from(uniqueMachoFiles.values());
 }
 
-async function isFatOrMacho(path: string): Promise<boolean> {
-    return !extname(path) && (await MachoFile.isMacho(path) || await FatFile.isFat(path));
+export async function isFatOrMacho(path: string): Promise<boolean> {
+    return (await MachoFile.isMacho(path) || await FatFile.isFat(path));
 }