Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[widgets][carousel] : ENG-7291 Improve text for Carousel field #3705

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

midhunadarvin
Copy link
Contributor

Description

  • update text field in the carousels component
  • update dependencies

Jira
https://builder-io.atlassian.net/browse/ENG-7291

Screenshot
Screenshot 2024-10-31 at 3 57 46 PM

@midhunadarvin midhunadarvin requested a review from a team as a code owner October 31, 2024 10:42
@midhunadarvin midhunadarvin requested review from teleaziz and removed request for a team October 31, 2024 10:42
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: d0b62b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@samijaber samijaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @midhunadarvin feel free to push the changes and update the package number in this same PR

@midhunadarvin
Copy link
Contributor Author

LGTM. @midhunadarvin feel free to push the changes and update the package number in this same PR

Updated package number and published the package. Faced issue mentioned here : #3638 , so I have fixed the dependency issue and published again. So there is a jump in the package version from 2.0.0 to 2.0.3

@midhunadarvin midhunadarvin merged commit 277a8db into BuilderIO:main Nov 5, 2024
48 checks passed
@midhunadarvin midhunadarvin deleted the ENG-7291 branch November 5, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants