Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[angular-gen2]: add angular 19 ssr e2e and fix hydration errors #3806

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sidmohanty11
Copy link
Contributor

@sidmohanty11 sidmohanty11 commented Dec 30, 2024

Description

Fixes the hydration error thrown from angular for using ngComponentOutlet, adds angular-19-ssr to e2e and an example of how users can override fetch to use HTTP client from angular that should help in caching HTTP requests

Jira
https://builder-io.atlassian.net/browse/ENG-7946
https://builder-io.atlassian.net/browse/ENG-7945
https://builder-io.atlassian.net/browse/ENG-7665

Screenshot
If relevant, add a screenshot or two of the changes you made.

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: 67ef1fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Dec 30, 2024

View your CI Pipeline Execution ↗ for commit 67ef1fc.

Command Status Duration Result
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 8m 16s View ↗
nx test @e2e/qwik-city ✅ Succeeded 7m 58s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 45s View ↗
nx test @e2e/gen1-react ✅ Succeeded 6m 18s View ↗
nx test @e2e/react-native ✅ Succeeded 6m 12s View ↗
nx test @e2e/sveltekit ✅ Succeeded 6m 2s View ↗
nx test @e2e/remix ✅ Succeeded 5m 57s View ↗
nx test @e2e/svelte ✅ Succeeded 5m 51s View ↗
Additional runs (35) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-01-02 10:55:04 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant