Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add loading animation while fetching course data #42

Conversation

Varundeep111
Copy link
Contributor

Added a loading animation to improve user experience while course data is being fetched from the backend. Previously, users would see an empty state message while data was loading, which could be confusing. Now, a spinner animation clearly indicates that data is being loaded.

  • Added loading state management in CourseSummaryController
  • Implemented SpinKitPulse loading animation from flutter_spinkit package
  • Added proper error handling with user feedback
  • Updated UI to show loading state before showing empty state or course data

Dependencies Added

  • flutter_spinkit: ^5.2.0

Notes for Reviewers

  • Loading animation color matches the app's accent color (0xFF4CAF50)
  • The loading state is managed through GetX observables
  • Error handling includes user-friendly snackbar messages

@angrezichatterbox angrezichatterbox self-requested a review November 11, 2024 03:21
@angrezichatterbox
Copy link
Member

Thanks for the PR @98021Varundeep Will get to review it soon :)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job on the PR, @98021Varundeep! The loading animation is excellent—it really enhances the user experience. If you’re up for it, could you also take a look at the remaining issues? Your insights would be incredibly valuable, and any suggestions you have to improve the app would be much appreciated!

@angrezichatterbox angrezichatterbox merged commit 02cd38b into Bunk-Mate:main Nov 11, 2024
1 check passed
@Varundeep111
Copy link
Contributor Author

Thank you so much! 🙌 I’m really glad you liked the loading animation—it’s rewarding to see it making a positive impact on the user experience. I’d be happy to dive into the remaining issues and share my thoughts. I’ll review them and see if there are opportunities for improvements or optimizations. Appreciate the feedback and trust—let’s keep enhancing the app! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants