Use core's filename transliteration

composer.json

@@ -71,6 +71,9 @@
             },
             "drupal/redirect": {
                 "Provided config does not match the config after an export": "https://www.drupal.org/files/issues/2932248-3.patch"
+            },
+            "drupal/core": {
+                "Use new Transliteration functionality in core for file names": "https://www.drupal.org/files/issues/2018-05-14/2492171-93.patch"
             }
         }
     },

drupal-org-core.make

@@ -3,3 +3,4 @@ core = 8.x
 projects[drupal][type] = core
 projects[drupal][download][url] = https://git.drupal.org/project/drupal.git
 projects[drupal][download][branch] = 8.6.x
+projects[drupal][patch][] = https://www.drupal.org/files/issues/2018-05-14/2492171-93.patch

modules/thunder_media/config/install/thunder_media.settings.yml

@@ -1,2 +1 @@
-enable_filename_transliteration: false
 enable_filefield_remove_button: false

modules/thunder_media/config/schema/thunder_media.schema.yml

@@ -1,9 +1,6 @@
 thunder_media.settings:
   type: config_object
   mapping:
-    enable_filename_transliteration:
-      type: boolean
-      label: 'Default transliteration'
     enable_filefield_remove_button:
       type: boolean
       label: 'Enable remove button'

modules/thunder_media/src/Form/ConfigurationForm.php

@@ -34,13 +34,6 @@ public function getFormId() {
   public function buildForm(array $form, FormStateInterface $form_state) {
     $config = $this->config('thunder_media.settings');
 
-    $form['enable_filename_transliteration'] = [
-      '#type' => 'checkbox',
-      '#title' => $this->t('Enable filename transliteration'),
-      '#description' => $this->t('Enable this checkbox to clean filenames before saving the files.'),
-      '#default_value' => $config->get('enable_filename_transliteration'),
-    ];
-
     $form['enable_filefield_remove_button'] = [
       '#type' => 'checkbox',
       '#title' => $this->t('Enable file field remove button'),
@@ -58,7 +51,6 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
     parent::submitForm($form, $form_state);
 
     $this->config('thunder_media.settings')
-      ->set('enable_filename_transliteration', $form_state->getValue('enable_filename_transliteration'))
       ->set('enable_filefield_remove_button', $form_state->getValue('enable_filefield_remove_button'))
       ->save();
   }

modules/thunder_media/thunder_media.module

@@ -5,31 +5,8 @@
  * Contains media related functions.
  */
 
-use Drupal\file\Entity\File;
 use Drupal\Core\Form\FormStateInterface;
 
-/**
- * Implements hook_ENTITY_TYPE_create().
- */
-function thunder_media_file_create(File $entity) {
-
-  $config = \Drupal::config('thunder_media.settings');
-
-  if ($config->get('enable_filename_transliteration')) {
-
-    $pathinfo = pathinfo($entity->getFilename());
-
-    /** @var \Drupal\pathauto\AliasCleaner $aliasCleaner */
-    $aliasCleaner = \Drupal::service('pathauto.alias_cleaner');
-
-    // Check for needed pathinfo array keys.
-    if (!empty($pathinfo['filename']) && !empty($pathinfo['extension'])) {
-      $cleanFilename = $aliasCleaner->cleanString($pathinfo['filename']) . '.' . $pathinfo['extension'];
-      $entity->setFilename($cleanFilename);
-    }
-  }
-}
-
 /**
  * Implements hook_preprocess_views_view().
  */

modules/thunder_media/thunder_media.post_update.php

@@ -0,0 +1,21 @@
+<?php
+
+/**
+ * @file
+ * Post update functions for Thunder.
+ */
+
+/**
+ * Move to core's filename transliteration functionality.
+ */
+function thunder_media_post_update_move_to_core_filename_transliteration() {
+
+  /** @var \Drupal\thunder_updater\Updater $thunderUpdater */
+  $thunderUpdater = \Drupal::service('thunder_updater');
+
+  \Drupal::config('system.file')->set('filename_transliteration', \Drupal::config('thunder_media.settings')->get('enable_filename_transliteration'));
+  \Drupal::config('thunder_media.settings')->clear('enable_filename_transliteration');
+
+  // Output logged messages to related channel of update execution.
+  return $thunderUpdater->logger()->output();
+}