Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Issue #3040605: Order of optional thunder modules install is wrong #669

Open
wants to merge 8 commits into
base: 8.x-2.x
Choose a base branch
from

Conversation

chrfritsch
Copy link
Member

@chrfritsch chrfritsch commented Mar 15, 2019

Make sure these boxes are checked before submitting your pull request - thank you!

  • All coding styles are fulfilled. (How to check for cs issues?)
  • All tests are running locally. (How to run the test?)
  • Necessary update hooks are provided.
  • User roles have correct access for new introduced permission.
  • Every thunder module has a README.md in its root. Follow this guidelines, but we don't need every topic.
  • Code is covered with well-balanced amount of inline comments.

If you are really awesome, then your feature is covered by additional tests. Well done!

@chrfritsch
Copy link
Member Author

I tried to remove the thunder_install module again in order to use
require_once $install_state['profiles']['thunder']->getPath() . '/src/Installer/Form/ModuleConfigureForm.php';

It loads the form, but the form has still service dependencies that could not be loaded. So I am wondering if loading files manually is really the best solution here.
Do you have another idea, @alexpott ?

@chrfritsch
Copy link
Member Author

Closing in favor of #672

@chrfritsch chrfritsch closed this Mar 19, 2019
@chrfritsch chrfritsch deleted the fix/3040605-order-install-tasks branch March 19, 2019 19:21
@chrfritsch chrfritsch restored the fix/3040605-order-install-tasks branch April 10, 2019 20:19
@chrfritsch chrfritsch reopened this Apr 10, 2019
* 8.x-2.x:
  Issue #3043522 by chr.fritsch, alexpott, mtodor: Update filter format weights
  Issue #3044793 by chr.fritsch, alexpott, mtodor: Fix download URLs for sandboxes in the drush makefile
  Issue #2846679 by chr.fritsch, mtodor: Two authors, but only one shown
  Issue #3039151 by chr.fritsch, mtodor: Switch to travis stages
  Issue #3040125 by chr.fritsch, daniel.bosen: Update libraries
  Issue #3041899 by daniel.bosen: Release Thunder 8.2.36
  Issue #3040605 by chr.fritsch, daniel.bosen: Tweak thunder install task logic
  Issue #2947071 by chr.fritsch, mtodor, daniel.bosen: Use update_helper module and remove thunder_updater
  Issue #3041383 by chr.fritsch, daniel.bosen, volkerk: Thunder modules installed hook should not expect module installation order
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant