Improve shell script robustness and error handling #65
+27
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `set -euo pipefail` to ensure the script exits on errors, undefined variables, or failed pipelines. - Enhanced error handling for SSH agent start and key addition, with clear error messages. - Replaced `echo` with `printf` for more reliable and formatted output. - Introduced optional legacy RSA hostkey handling based on input parameters. - Improved overall script readability with clearer variable names and structured conditionals.
|
Thank you for your contribution! Will review it |
|
@Burnett01 any news? |
|
looks good so far, I will get back to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set -euo pipefailto ensure the script exits on errors, undefined variables, or failed pipelines.echowithprintffor more reliable and formatted output.