Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotag is broken: stable branch needs to use at least node14 instead of node13 #45

Open
JodliDev opened this issue Nov 3, 2023 · 5 comments

Comments

@JodliDev
Copy link

JodliDev commented Nov 3, 2023

Issue:
butlerlogic/action-autotag@stable uses node13 but also makes use of the most recent version of other libraries (notably https://github.com/nodejs/undici) which need >= node14.

This leads to the following warnings when building:

  #9 2.892 npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=14.0"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 2.892 npm WARN notsup Not compatible with your version of node/npm: [email protected]
  #9 2.893 npm WARN notsup Unsupported engine for @fastify/[email protected]: wanted: {"node":">=14"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 2.893 npm WARN notsup Not compatible with your version of node/npm: @fastify/[email protected]

So far this has not caused problems. But in version v5.27.1 of undici they started using optional chaining (which is only supported in >= node14).
Luckily because of their incredible response time (and me missing that the issue was actually caused by autotag and not their library) they worked around the issue in version v5.27.2 before I could close the issue again. But you might update the stable branch to at least node14 to get rid of the warnings when building and in case optional chaining (or other features) is introduced again in any other library.

The problem resurfaced again in version v5.28.0 which means autotag is now broken again.

The problem is explained in more detail here (it is focused on version v5.27.1 which they changed afterwards. but exactly the same problem was introduced again in v5.28.0,):
nodejs/undici#2399

How To Reproduce:
Just build action-autotag@stable and notice the warnings.

Expected Behavior:
Either not use the most recent versions of other libraries or update nodeJS to version 14 or above.

Full terminal output (notice warnings in #9)

/usr/bin/docker build -t 8a3030:9da51c9b1b394e38bcad9fe306105ad4 -f "/home/runner/work/_actions/butlerlogic/action-autotag/stable/Dockerfile" "/home/runner/work/_actions/butlerlogic/action-autotag/stable"
  #0 building with "default" instance using docker driver
  
  #1 [internal] load .dockerignore
  #1 transferring context: 2B done
  #1 DONE 0.0s
  
  #2 [internal] load build definition from Dockerfile
  #2 transferring dockerfile: 154B done
  #2 DONE 0.0s
  
  #3 [internal] load metadata for docker.io/library/node:13-alpine
  #3 ...
  
  #4 [auth] library/node:pull token for registry-1.docker.io
  #4 DONE 0.0s
  
  #3 [internal] load metadata for docker.io/library/node:13-alpine
  #3 DONE 1.1s
  
  #5 [internal] load build context
  #5 transferring context: 24.42kB done
  #5 DONE 0.0s
  
  #6 [1/4] FROM docker.io/library/node:13-alpine@sha256:527c70f74817f6f6b5853588c28de33459178ab72421f1fb7b63a281ab670258
  #6 resolve docker.io/library/node:13-alpine@sha256:527c70f74817f6f6b5853588c28de33459178ab72421f1fb7b63a281ab670258 done
  #6 sha256:780514bed1adda642a7f7008ea5b1477bb78a23e3f76eabbdde21031b2185a2f 11.53MB / 35.30MB 0.2s
  #6 sha256:5d74fb112a7d313344f9f679ccb975062377464235fac36e1b952aa2b125d5e2 2.24MB / 2.24MB 0.2s done
  #6 sha256:527c70f74817f6f6b5853588c28de33459178ab72421f1fb7b63a281ab670258 1.65kB / 1.65kB done
  #6 sha256:4d6b35f8d14b2f476005883f9dec0a93c83213838fd3def3db0d130b1b148653 1.16kB / 1.16kB done
  #6 sha256:8216bf4583a5d422edd579a3b77f66a8fe127c4acb5eabecf085d911786f3e68 6.77kB / 6.77kB done
  #6 sha256:cbdbe7a5bc2a134ca8ec91be58565ec07d037386d1f1d8385412d224deafca08 2.81MB / 2.81MB 0.1s done
  #6 extracting sha256:cbdbe7a5bc2a134ca8ec91be58565ec07d037386d1f1d8385412d224deafca08
  #6 sha256:4b9536424fa1675675e7edd59ae9a92573f0c010c5458733a493e2c3e1daf1ae 0B / 283B 0.2s
  #6 sha256:780514bed1adda642a7f7008ea5b1477bb78a23e3f76eabbdde21031b2185a2f 30.41MB / 35.30MB 0.3s
  #6 extracting sha256:cbdbe7a5bc2a134ca8ec91be58565ec07d037386d1f1d8385412d224deafca08 0.1s done
  #6 sha256:4b9536424fa1675675e7edd59ae9a92573f0c010c5458733a493e2c3e1daf1ae 283B / 283B 0.2s done
  #6 sha256:780514bed1adda642a7f7008ea5b1477bb78a23e3f76eabbdde21031b2185a2f 35.30MB / 35.30MB 0.4s done
  #6 extracting sha256:780514bed1adda642a7f7008ea5b1477bb78a23e3f76eabbdde21031b2185a2f
  #6 extracting sha256:780514bed1adda642a7f7008ea5b1477bb78a23e3f76eabbdde21031b2185a2f 1.6s done
  #6 extracting sha256:5d74fb112a7d313344f9f679ccb975062377464235fac36e1b952aa2b125d5e2
  #6 extracting sha256:5d74fb112a7d313344f9f679ccb975062377464235fac36e1b952aa2b125d5e2 0.1s done
  #6 extracting sha256:4b9536424fa1675675e7edd59ae9a92573f0c010c5458733a493e2c3e1daf1ae done
  #6 DONE 2.4s
  
  #7 [2/4] ADD ./app /app
  #7 DONE 0.0s
  
  #8 [3/4] WORKDIR /app
  #8 DONE 0.0s
  
  #9 [4/4] RUN cd /app && npm i
  #9 2.892 npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":">=14.0"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 2.892 npm WARN notsup Not compatible with your version of node/npm: [email protected]
  #9 2.893 npm WARN notsup Unsupported engine for @fastify/[email protected]: wanted: {"node":">=14"} (current: {"node":"13.14.0","npm":"6.14.4"})
  #9 2.893 npm WARN notsup Not compatible with your version of node/npm: @fastify/[email protected]
  #9 2.893 npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
  #9 2.893 
  #9 2.894 added 62 packages from 77 contributors and audited 62 packages in 2.329s
  #9 2.913 
  #9 2.913 2 packages are looking for funding
  #9 2.913   run `npm fund` for details
  #9 2.913 
  #9 2.913 found 0 vulnerabilities
  #9 2.913 
  #9 DONE 3.0s
  
  #10 exporting to image
  #10 exporting layers
  #10 exporting layers 0.6s done
  #10 writing image sha256:f2927ab6726cdeaaf8fa262939865bc1ac0da05cd9ceaa69de90cad12089e73c done
  #10 naming to docker.io/library/8a3030:9da51c9b1b394e38bcad9fe306105ad4 done
  #10 DONE 0.7s
@JodliDev
Copy link
Author

undici pushed a new update that broke autotag - it now is basically the same error (usage of optional chaining) just from a different script.
Since they cannot be expected to use outdated syntax just because of autotag, unfortunately this action is officially broken until the docker container is fixed :(

@panuhorsmalahti
Copy link

Correct, this action is broken here as well.

@JodliDev JodliDev changed the title stable branch needs to use at least node14 instead of node13 Autotag is broken: stable branch needs to use at least node14 instead of node13 Nov 24, 2023
@JodliDev
Copy link
Author

Workaround for now is to use butlerlogic/[email protected] instead of butlerlogic/action-autotag@stable

@dycw
Copy link

dycw commented Nov 24, 2023

Is it worth pinging the author on this? I've actually been relying on this autotag for years, and its stability really has been amazing...until 7 hours ago!

@baptisteArno
Copy link

Same here 🥲

glind added a commit to buildly-release-management/buildly-core that referenced this issue Mar 25, 2024
patelradhika added a commit to buildly-release-management/buildly-core that referenced this issue Apr 30, 2024
* Update prod-build.yml

Workaround for ButlerLogic/action-autotag#45

* initial stripe changes

* order by descending subscription end date to get the latest entry

* fix github action for artifact registry

* fix invite link

* patch release

* fix patch version

---------

Co-authored-by: Greg Lind <[email protected]>
Co-authored-by: Radhika Patel <[email protected]>
patelradhika added a commit to buildly-release-management/buildly-core that referenced this issue May 29, 2024
* Update prod-build.yml

Workaround for ButlerLogic/action-autotag#45

* initial stripe changes

* order by descending subscription end date to get the latest entry

* fix github action for artifact registry

* fix invite link

* patch release

* fix patch version

* patch version

---------

Co-authored-by: Greg Lind <[email protected]>
Co-authored-by: Peter Odeny <[email protected]>
patelradhika added a commit to buildly-release-management/buildly-core that referenced this issue Aug 20, 2024
* Update prod-build.yml

Workaround for ButlerLogic/action-autotag#45

* initial stripe changes

* order by descending subscription end date to get the latest entry

* fix github action for artifact registry

* fix invite link

* patch release

* fix patch version

* patch version

* cancel subscriptions

* implement subscription cancellation

* change insights to labs

---------

Co-authored-by: Greg Lind <[email protected]>
Co-authored-by: Peter Odeny <[email protected]>
patelradhika added a commit to buildly-release-management/buildly-core that referenced this issue Aug 26, 2024
* Update prod-build.yml

Workaround for ButlerLogic/action-autotag#45

* initial stripe changes

* order by descending subscription end date to get the latest entry

* fix github action for artifact registry

* fix invite link

* patch release

* fix patch version

* patch version

* cancel subscriptions

* implement subscription cancellation

* change insights to labs

* fix unit test github action

* patch version

---------

Co-authored-by: Greg Lind <[email protected]>
Co-authored-by: Peter Odeny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants