Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSD-1685: Github Action tag/release fix #1619

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

EdwinGuzman
Copy link
Member

Fixes JIRA ticket DSD-1685

This PR does the following:

  • I think this should be enough to fix the issue we keep encountering. The GITHUB_TOKEN value is not read because it's not an accepted value in under the "with" property.

How has this been tested?

Not yet, not until the next release.

Accessibility concerns or updates

  • N/A

Checklist:

  • I have updated the Storybook documentation accordingly.
  • I have added relevant accessibility documentation for this pull request.
  • All new and existing tests passed.

Front End Review:

  • Review the Vercel preview deployment once it is ready.

@EdwinGuzman EdwinGuzman added the Needs Review Pull requests that are ready for peer review. label Jun 10, 2024
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 4:06pm

Copy link
Collaborator

@bigfishdesign13 bigfishdesign13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bigfishdesign13 bigfishdesign13 added Ship It Pull requests that have been reviewed and approved. and removed Needs Review Pull requests that are ready for peer review. labels Jun 11, 2024
@@ -23,8 +23,9 @@ jobs:
- name: Tag
id: autotagger
uses: butlerlogic/action-autotag@stable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A version number needs to be specified here instead of stable. Others have said 1.1.2 worked for them.

@EdwinGuzman EdwinGuzman merged commit bee4218 into development Jun 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It Pull requests that have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants