update response structure to echo schema expected from TS defs and v1 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@courcelan I'm wondering if maybe it would be good to get @zanderle as a second reviewer on this one (since Orly is out?) I'm not the best person to review these SDK changes and this SDK is pretty important. However, I know that in order to get the autoversionining and CI/CD to deploy, the commit message has to start with |
…and v1 This updates the response structure to echo schema expected from TypeScript definitions and the same data schema/structure as return in buttercms-js version 1. The response no longer returns the `xsrfCookieName`, `xsrfHeaderName`, and `maxContentLength` in `response.config` as they are not in use by native fetch. Additionally, `response.config` returns only the fully formed `url` (`response.config.url`) rather than breaking it down in discrete parts. If needed, please use the native `URL` API in your code to get similar datapoints. This PR fixes the issues raised in #89. bump package version to 2.1.0
courcelan
force-pushed
the
update-response-structure
branch
from
dbb1db2 to
1a748fa
Compare
|
squashed with the feat prefix and added @zanderle to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the response structure to echo schema expected from TypeScript definitions and the same data schema/structure as return in buttercms-js version 1.
The response no longer returns the
xsrfCookieName,xsrfHeaderName, andmaxContentLengthinresponse.configas they are not in use by native fetch. Additionally,response.configreturns only the fully formedurl(response.config.url) rather than breaking it down in discrete parts. If needed, please use the nativeURLAPI in your code to get similar datapoints.This PR fixes the issues raised in #89.
bump package version to 2.1.0