Adds keybinding for 'c' to toggle sorting by number of items #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
approved these changes
Dec 9, 2023
src/interactive/app/common.rs
Outdated
| MTimeAscending => MTimeDescending, | ||
| MTimeDescending => MTimeAscending, | ||
| _ => MTimeAscending, |
There was a problem hiding this comment.
Switching the default sort-direction without commenting on it seems like an accident to me.
src/interactive/app/common.rs
Outdated
| *self = match self { | ||
| CountAscending => CountDescending, | ||
| CountDescending => CountAscending, | ||
| _ => CountAscending, |
There was a problem hiding this comment.
Maybe it's because Size starts descending, even though the default value suggests otherwise?
I set it to be Descending now consistently, which is nice from a UX point of view (as it's what feels natural).
Those don't have a count in that sense, and that needs to be visible when sorting. Now files, which naturally have no count, will sort alphabetically instead which seems most natural, as they are technically out of scope.
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds keybinding for 'c' to toggle sorting by number of items. I have used
human_formatto convert numbers to more human readable form.Number of items in each directory is collected the same way as the size was done before during file system traversal. I have updated the tests to ensure the counts are calculated correctly.
Sorting by number of items + current sorting mode in the footer:
