Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displays total item count #189

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Displays total item count #189

merged 2 commits into from
Dec 9, 2023

Conversation

gosuwachu
Copy link
Contributor

Before:
Screenshot 2023-12-09 at 14 19 59

After:
Screenshot 2023-12-09 at 14 19 49

@gosuwachu gosuwachu mentioned this pull request Dec 9, 2023
Closed
@Byron
feat: Add total size to header bar and change to aggregate, human-rea…
3241022 
…dable item count.

This changes the display from `(2034 items)` to
`(2k items, 213 MB)`, providing an overview of the total amount
of storage used along with the total amount of files on a particular
hiearchy level.
Byron
Byron approved these changes Dec 9, 2023
View reviewed changes
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that's a great idea!

This inspired me to also add the aggregate size of the hierarchical level, which now looks like this:

Screenshot 2023-12-09 at 19 02 55

@Byron Byron linked an issue Dec 9, 2023 that may be closed by this pull request
Feature request: have "number of files" as a display/sort option #144
Closed
@Byron Byron merged commit ba2efe4 into Byron:main Dec 9, 2023
2 checks passed
@gosuwachu
Copy link
Contributor Author

Nice! Looks great.

@gosuwachu gosuwachu deleted the total_item_count branch December 9, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: have "number of files" as a display/sort option
3 participants
@gosuwachu @Byron @piotrwach