fix: EntryData size test passes on 32-bit (#197) #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EntryData doesn't need to be exactly 80 to test memory consumption, just less than it.
|
Thanks a lot for your help! In future, if you feel like adding dev-dependencies that you made good experiences with, please feel free to do so. I am always looking for new crates that make testing better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the EntryData size test to pass on 32-bit targets. This has been proven to work in CI here: void-linux/void-packages#47626.
There are crates like assertables and more_asserts that offer an
assert_eq!-like interface for less-than-or-equal-to comparisons if you'd prefer that, but I didn't want to add a dependency on your behalf.Closes #197.