Adds the missing '/' prefix for root directories #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
add_missing_slash_in_root_dir
branch
from
6f513b5
to
94c008f
Compare
Byron
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks a lot, a great catch!
Not showing the prefix / on the root is fully intentional, even though it now doesn't work as it was supposed to anymore. The general idea is that path given by the user are left verbatim.
I re-added some logic that will detect typical user-specified paths, but not all of them due to ambiguity.
Of course, there would be a way to do it perfectly, but I thought it wasn't worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
