Option to enable debug logs #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncludes panics. Previously, when `dua i` was used, panics would be hard to observe, if at all, as they would print to the alternate screen. Now, when the `--log-file dua.log` is specified, the panic will be emitted into the log file instead and thus won't be lost anymore. This may help with debugging in future.
Byron
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Thanks a lot, a great idea!
The bare-bones feature didn't seem too useful, but it turns out there is a wonderful log-panics crate which works as advertised. Seeing panics properly fixes a serious issue I had in the rare occasion that dua i did crash on me - now the panic will just be written into the log file, with backtrace even.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find logs very useful. So far I had to keep applying this patch on top of my changes. It would be useful to add this option to the cli to help with debugging. I hope the logs will improve in the future to include more interesting info abouy the operation of the program.