Draft: explore gix APIs, experiment with gix-blame API #1453
Commits on Aug 21, 2024
-
This is not a material change as the loop gets only executed once. It is mostly to keep indentation changes in a separate commit.
-
-
Commits on Aug 22, 2024
Commits on Aug 23, 2024
-
There’s an exit condition `parent_ids.is_empty()` which is sufficient for the first test case.
-
Move new_lines_to_blame out of closure
Otherwise, diffs with more than one hunk would yield incorrect results.
-
-
-
-
-
-
Skip commits that don’t affect file
This required merging the separate setup section into the loop, in order to be able to use `continue` when a diff did not contain changes for the path currently being blamed.
-
-
Commits on Aug 25, 2024
Commits on Aug 26, 2024
Commits on Aug 28, 2024
-
Split DiffRecorder into ChangeRecorder and process_changes
This is supposed to simplify the algorithm by reducing the state we need to keep track of. We also don’t have to run the `for` loop on every call to `process_change` anymore.
-
Commits on Aug 30, 2024
Commits on Aug 31, 2024
Commits on Sep 4, 2024
-
Add UnblamedHunk to be able to track offset
This is necessary for keeping track of deleted hunks in a file.
Commits on Sep 8, 2024
-
Correctly handle non-inclusive end
Make change not a reference to be able to return new, non-reference values from match arms.
-
-
-
Keep two ranges in UnblamedHunk for clarity
Before, the distinction between line numbers in the blamed file vs. line numbers in the file currently being examined was not always clear, particularly not when you were not familiar with how `UnblamedHunk` was supposed to work.
-
Better separate offset and offset_in_destination
`offset` is a property of an `UnblamedHunk`. It tells you by how many lines `range_in_destination` and `range_in_blamed_file` have diverged. `offset_in_destination`, on the other hand, keeps track of how many lines have been added in a single iteration of `process_changes`. This value is, at certain points, used as an input to `UnblamedHunk::new`.
-
-
Commits on Sep 9, 2024
Commits on Sep 16, 2024
Commits on Sep 17, 2024
-
-
-
-
-
Add more tests for unchanged lines
Add assertions related to offset
-
-
-
-
-
-
-
-
-
-
-
Commits on Sep 19, 2024
Commits on Sep 20, 2024
-
Don't consume addition preceding unblamed hunk
The addition might match subsequent unblamed hunks.
-
Don't consume unchanged lines preceding unblamed hunk
The unchanged lines might match subsequent unblamed hunks.
-
Change offset for changes when there is no hunk
At this point, this is not strictly necessary as the changes to `offset_in_destination` are not read anywhere yet after they are changed in the added branches.
-
Don't consume deletion preceding unblamed hunk
The deletion might match subsequent unblamed hunks.
-
Don't consume unblamed hunk following deletion
There might be more changes that are supposed to affect the unblamed hunk. The deletion might, for example, be followed by another deletion or by an addition both of which would have an effect on the offset that needs to be applied to the unblamed hunk.