add contrib/lockfile #255
Merged
add contrib/lockfile #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2fo-cibot
bot
added
size/XXL
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new package (contrib/lockfile) that implements an advisory locking mechanism for VFS files along with corresponding tests and documentation. Key changes include adding the new lockfile package with its functions and tests, updating the README and related documentation, and renaming functions in the SFTP backend (e.g., getSShConfig to getSSHConfig) for consistency.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/utils.go | Added package-level documentation. |
| utils/authority/authority.go | Updated comment text for consistency. |
| options/* | Added package-level documentation. |
| contrib/lockfile/* | New package implementation with tests and documentation. |
| backend/sftp/* | Renamed functions (getSShConfig → getSSHConfig) and updated tests. |
| backend/ftp/, backend/azure/ | Minor improvements and style updates. |
| .github/workflows/golangci-lint.yml | Updated linter action version. |
dustin-schnee
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254