This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
Implementation of Hostname Verification when connecting to any endpoint #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graju256
reviewed
Nov 2, 2021
| return true; | ||
| } else { | ||
| try { | ||
| throw new SSLPeerUnverifiedException("Cannot verify hostname: " + hostname); |
There was a problem hiding this comment.
Throwing the exception and catching it immediately doesn't make any sense.
You can remove this try-catch block.
graju256
reviewed
Nov 2, 2021
| @@ -162,4 +165,22 @@ public void checkServerTrusted(X509Certificate[] chain, String s) throws Certifi | |||
| public X509Certificate[] getAcceptedIssuers() { | |||
| return new X509Certificate[0]; | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean verify(String hostname, SSLSession session) { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we connecting to any end point, we were allowing any hostname. But there are request where we need to mandate host name verification. We are providing option to enable/disable hostname verification. By default, it will be disabled or go with the default behavior.