Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic code for Saas and on-prem dispatcher certificate. #107

Open
wants to merge 5 commits into
base: develop/portal
Choose a base branch
from
Open

Generic code for Saas and on-prem dispatcher certificate. #107

wants to merge 5 commits into from

Conversation

murthyravi14
Copy link

Description of the change

Benefits

Drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • [] Chart version bumped in Chart.yaml according to semver.
  • [] Variables are documented in the README.md
  • [] Title of the PR starts with chart name (e.g. [charts/gateway])
  • [] If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

@murthyravi14 murthyravi14 changed the base branch from stable to develop/portal December 6, 2021 10:09
kk632390
kk632390 reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@kk632390 kk632390 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • As solr is removed, solr related certs needs to be removed from portal-internal-secret
  • Its good to have description for the newly added fields tls:
    saas: false ..both in values file and readme
  • value-production.yaml should have tls: saas field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kk632390 kk632390 kk632390 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murthyravi14 @kk632390