Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe BIOS met data through CRU routines for weather generation #394

Merged

Conversation

Whyborn
Copy link

@Whyborn Whyborn commented Sep 6, 2024

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Piping the BIOS met inputs (the AGCD dataset) through the routines developed for the CRU routines. There are two options:

  1. Make some adjustments to the existing CRU routines to have different options for weather generators, so that it uses the appropriate fields to prepare the weather generator.
  2. Leave the BIOS met routines where they are, but make the file look very similar to the offline/cable_cru_TRENDY.F90 file.

Upside of 1 is that it paves the way for work necessary in the long term for generalising inputs. Only upside to 2 is that is it probably easier, but not necessarily. Both approaches require some thorough investigation to determine which bits of the BIOS init routines are only relevant to the met forcing, and which are relevant to BLAZE.

Fixes #391

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Please add a reviewer when ready for review.

@Whyborn Whyborn added this to the BIOS3 milestone Sep 6, 2024
@Whyborn Whyborn self-assigned this Sep 6, 2024
@abhaasgoyal abhaasgoyal added the priority:high High priority issues that should be included in the next release. label Sep 6, 2024
@Whyborn Whyborn changed the title Add indices for AGCD met data Pipe BIOS met data through CRU routines for weather generation Sep 9, 2024
@AlisonBennett
Copy link

AlisonBennett commented Sep 9, 2024 via email

@Whyborn Whyborn merged commit 8cac730 into CABLE-POP_TRENDY Oct 17, 2024
1 check failed
@Whyborn Whyborn deleted the 391-Pipe-BIOS-met-inputs-through-CRU-routines branch October 17, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High priority issues that should be included in the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants