Skip to content

Commit

Permalink
Add requested changes from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
SeanBryan51 committed Sep 20, 2023
1 parent ef75799 commit 24b7fe4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 2 additions & 4 deletions benchcab/benchcab.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,8 @@ def build(self):
modules=self.config["modules"], verbose=self.args.verbose
)
else:
print(
f"Compiling CABLE {'with MPI' if internal.MPI else 'serially'} for "
f"realisation {repo.name}..."
)
build_mode = "with MPI" if internal.MPI else "serially"
print(f"Compiling CABLE {build_mode} for realisation {repo.name}...")
repo.pre_build(verbose=self.args.verbose)
repo.run_build(

Check warning on line 207 in benchcab/benchcab.py

View check run for this annotation

Codecov / codecov/patch

benchcab/benchcab.py#L204-L207

Added lines #L204 - L207 were not covered by tests
modules=self.config["modules"], verbose=self.args.verbose
Expand Down
1 change: 1 addition & 0 deletions tests/test_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def test_post_build():
(tmp_dir / internal.CABLE_EXE).touch()
repo = get_mock_repo()
repo.post_build()
assert not (offline_dir / ".tmp" / internal.CABLE_EXE).exists()
assert (offline_dir / internal.CABLE_EXE).exists()

# Success case: test non-verbose standard output
Expand Down

0 comments on commit 24b7fe4

Please sign in to comment.