Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force custom build to use specified modules #110

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

SeanBryan51
Copy link
Collaborator

This change forces the custom build script to use the modules specified in the config file. This is done so that we ensure we are using the same modules when compiling and running CABLE.

Fixes #94

@SeanBryan51 SeanBryan51 linked an issue Jul 17, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #110 (677d761) into master (b829293) will increase coverage by 0.21%.
The diff coverage is 96.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   88.26%   88.48%   +0.21%     
==========================================
  Files          26       26              
  Lines        1364     1372       +8     
==========================================
+ Hits         1204     1214      +10     
+ Misses        160      158       -2     
Impacted Files Coverage Δ
benchcab/benchcab.py 35.52% <0.00%> (+0.46%) ⬆️
benchcab/repository.py 98.73% <91.66%> (-0.04%) ⬇️
tests/test_repository.py 100.00% <100.00%> (ø)

This change forces the custom build script to use the modules specified
in the config file. This is done so that we ensure we are using the same
modules when compiling and running CABLE.

Fixes #94
@SeanBryan51 SeanBryan51 force-pushed the 94-force-custom-build-to-use-specified-modules branch from f7b9509 to cdff092 Compare July 17, 2023 03:47
Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@SeanBryan51 SeanBryan51 merged commit bfb95fe into master Jul 21, 2023
3 checks passed
@SeanBryan51 SeanBryan51 deleted the 94-force-custom-build-to-use-specified-modules branch July 21, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should specify modules per branch/realisation
2 participants