Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove synonymous names for 'fluxsite' #111

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

SeanBryan51
Copy link
Collaborator

Currently, there is inconsistent naming conventions being used to describe fluxsite tests which can be confusing for developers and users. These include names such as 'site', 'single site', 'fluxsite', 'fluxnet', etc. This change replaces all occurrences of these names in the code base and documentation with 'fluxsite'.

We choose 'fluxsite' as this describes the nature of the tests (as opposed to 'fluxnet' which describes a product/network).

Fixes #62

Currently, there is inconsistent naming conventions being used to
describe fluxsite tests which can be confusing for developers and users.
These include names such as 'site', 'single site', 'fluxsite',
'fluxnet', etc. This change replaces all occurrences of these names in
the code base and documentation with 'fluxsite'.

We choose 'fluxsite' as this describes the nature of the tests (as
opposed to 'fluxnet' which describes a product/network).

Fixes #62
@SeanBryan51 SeanBryan51 linked an issue Jul 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #111 (b829293) into master (8acd685) will not change coverage.
The diff coverage is 79.31%.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files          26       26           
  Lines        1364     1364           
=======================================
  Hits         1204     1204           
  Misses        160      160           
Impacted Files Coverage Δ
benchcab/cli.py 100.00% <ø> (ø)
benchcab/comparison.py 61.36% <ø> (ø)
benchcab/utils/pbs.py 100.00% <ø> (ø)
tests/test_pbs.py 100.00% <ø> (ø)
benchcab/benchcab.py 35.06% <27.58%> (ø)
benchcab/internal.py 90.47% <80.00%> (ø)
benchcab/task.py 83.00% <87.50%> (ø)
benchcab/benchtree.py 100.00% <100.00%> (ø)
tests/test_benchcab.py 100.00% <100.00%> (ø)
tests/test_benchtree.py 100.00% <100.00%> (ø)
... and 3 more

Copy link
Collaborator

@ccarouge ccarouge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@SeanBryan51 SeanBryan51 merged commit f3ed8c0 into master Jul 18, 2023
2 of 3 checks passed
@SeanBryan51 SeanBryan51 deleted the 62-remove-synonymous-names-for-fluxnet branch July 18, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove synonymous names for fluxnet
2 participants