Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify absolute path to benchcab executable #117

Merged
merged 3 commits into from
Jul 26, 2023

Commits on Jul 19, 2023

  1. Specify absolute path to benchcab executable

    This change specifies the absolute path to the benchcab executable in
    the job script so that we don't run into path issues when running using
    a 'locally installed' version of benchcab. This will be helpful making
    code changes and testing them on NCI.
    
    Fixes #95
    SeanBryan51 committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    c969c5e View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Add requested changes from code review

    We should not use a default value when trying to infer the path to the
    benchcab executable. If the path is undefined, we raise an exception as
    this is likely a sign that the user's PATH variable is configured
    incorrectly.
    
    Co-authored-by: Claire Carouge <[email protected]>
    SeanBryan51 and ccarouge committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    9238d08 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Configuration menu
    Copy the full SHA
    b5c1956 View commit details
    Browse the repository at this point in the history