Organise unit tests to use pytest fixtures (test_repository.py implementation)
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanBryan51
changed the title
test_repository.py implementation)
Codecov Report
@@ Coverage Diff @@
## 163-tidy-up-organisation-of-unit-tests #176 +/- ##
===========================================================================
+ Coverage 46.42% 60.45% +14.03%
===========================================================================
Files 25 25
Lines 1676 1659 -17
===========================================================================
+ Hits 778 1003 +225
+ Misses 898 656 -242
|
ccarouge
requested changes
Oct 10, 2023
| (internal.SRC_DIR / repo.name / "offline" / "Makefile").touch() | ||
| (internal.SRC_DIR / repo.name / "offline" / "parallel_cable").touch() | ||
| (internal.SRC_DIR / repo.name / "offline" / "serial_cable").touch() | ||
| (internal.SRC_DIR / repo.name / "offline" / "foo.f90").touch() |
There was a problem hiding this comment.
Should we add a teardown?
There was a problem hiding this comment.
I figured all directories under the mock_cwd are removed at the end by the _run_around_tests fixture which is why I haven't been adding a teardown step.
There was a problem hiding this comment.
Could we have a comment at the file level to remind us of that? Happy to have the same comment in all test_* files. But I am sure to have forgotten in a few days otherwise.
There was a problem hiding this comment.
Sure, we can put a comment the module docstring, e.g:
"""`pytest` tests for `repository.py`.
Note: explicit teardown for generated files and directories are not required as
the working directory used for testing is cleaned up in the `_run_around_tests`
pytest autouse fixture.
"""Add missing `parametrize()` decorator.
ccarouge
approved these changes
Oct 11, 2023
Add note on cleaning up generated files and directories in the tests.
SeanBryan51
merged commit b3a0fac
into
163-tidy-up-organisation-of-unit-tests
4 checks passed
SeanBryan51
deleted the
163-tidy-up-organisation-of-unit-tests-test_repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.