Add parse and dispatch strategy #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove tests as they are not compatible with new API changes to the Benchcab class. Tests relating to executing PBS commands will be a part of the PBS wrapper implementation.
Codecov Report
@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 86.74% 85.19% -1.55%
==========================================
Files 27 27
Lines 1396 1385 -11
==========================================
- Hits 1211 1180 -31
- Misses 185 205 +20
|
SeanBryan51
force-pushed
the
196-implement-parse-and-dispatch-strategy-for-executing-subcommands
branch
2 times, most recently
from
16f9766
to
6e201d6
Compare
SeanBryan51
force-pushed
the
196-implement-parse-and-dispatch-strategy-for-executing-subcommands
branch
from
6e201d6
to
2cbdf2a
Compare
SeanBryan51
commented
Nov 6, 2023
benchcab/benchcab.py
Outdated
| """A helper method that initialises and returns the `tasks` attribute.""" | ||
| repos = [ |
There was a problem hiding this comment.
This should call the _get_repos method.
benchcab/benchcab.py
Outdated
| @@ -102,21 +93,41 @@ def _validate_environment(self, project: str, modules: list): | |||
| ) | |||
| sys.exit(1) | |||
|
|
|||
| def _initialise_tasks(self) -> list[Task]: | |||
| @functools.cache | |||
There was a problem hiding this comment.
After looking at this again, functools.cache might be a bit overkill. It also looks like functions that take in a dictionary cannot be memoized with functools.cache. We can achieve caching here by setting an initial value for self.config to None and only read the config if self.config == None, else return the value of self.config.
The current method of executing subcommands can be improved using a "parse and dispatch" strategy. Whereby you don't need to run a conditional to work out which subcommand to use. This change refactors the Benchcab class so that its "public" methods can be dispatched easily when inspecting the argparse.Namespace object returned by the command line parser. Fixes #196
SeanBryan51
force-pushed
the
196-implement-parse-and-dispatch-strategy-for-executing-subcommands
branch
from
2cbdf2a
to
474d183
Compare
bschroeter
approved these changes
Nov 7, 2023
|
Integration tests seem to be working. Merging now. |
SeanBryan51
deleted the
196-implement-parse-and-dispatch-strategy-for-executing-subcommands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method of executing subcommands can be improved using a "parse and dispatch" strategy. Whereby you don't need to run a conditional to work out which subcommand to use.
This change refactors the Benchcab class so that its "public" methods can be dispatched easily when inspecting the argparse.Namespace object returned by the command line parser.
Fixes #196